RESOLVED FIXED 67358
[skia] States of GraphicsContext may never be restored after clipToImageBuffer 
https://bugs.webkit.org/show_bug.cgi?id=67358
Summary [skia] States of GraphicsContext may never be restored after clipToImageBuffer
Robin Cao
Reported 2011-08-31 22:19:00 PDT
States of GraphicsContext may never be restored after clipToImageBuffer. Skia doesn't support clipping to an image, so it creates a layer to implement this. See PlatformContextSkia::beginLayerClippedToImage and PlatformContextSkia::applyClipFromImage But in some cases, such as clipping to an empty ImageBuffer, beginLayerClippedToImage/applyClipFromImage are mismatched, which will make states of GraphicsContext busted.
Attachments
patch (5.16 KB, patch)
2011-09-01 01:28 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2011-09-01 01:28:14 PDT
Created attachment 105923 [details] patch
Robin Cao
Comment 2 2011-09-01 20:46:48 PDT
CCing experts on this area.
James Robinson
Comment 3 2011-09-06 11:00:09 PDT
Comment on attachment 105923 [details] patch R=me
WebKit Review Bot
Comment 4 2011-09-06 11:12:26 PDT
Comment on attachment 105923 [details] patch Clearing flags on attachment: 105923 Committed r94581: <http://trac.webkit.org/changeset/94581>
WebKit Review Bot
Comment 5 2011-09-06 11:12:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.