Bug 67352 - WebGLContextEvent should have its own JS wrapper
Summary: WebGLContextEvent should have its own JS wrapper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 19:51 PDT by Sam Weinig
Modified: 2011-09-01 11:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.84 KB, patch)
2011-08-31 19:55 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (20.38 KB, patch)
2011-09-01 09:37 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (20.48 KB, patch)
2011-09-01 09:52 PDT, Sam Weinig 		andersca: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-08-31 19:51:21 PDT 
WebGLContextEvent should have its own JS wrapper
Comment 1 Sam Weinig 2011-08-31 19:55:10 PDT 
Created attachment 105887 [details]
Patch
Comment 2 Early Warning System Bot 2011-08-31 20:03:24 PDT 
Comment on attachment 105887 [details]
Patch

Attachment 105887 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9581072
Comment 3 WebKit Review Bot 2011-08-31 20:34:38 PDT 
Comment on attachment 105887 [details]
Patch

Attachment 105887 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9578222

New failing tests:
fast/canvas/webgl/WebGLContextEvent.html
Comment 4 Sam Weinig 2011-09-01 09:37:35 PDT 
Created attachment 105978 [details]
Patch
Comment 5 Sam Weinig 2011-09-01 09:52:15 PDT 
Created attachment 105982 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-01 10:54:48 PDT 
Comment on attachment 105982 [details]
Patch

Attachment 105982 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9586082

New failing tests:
fast/canvas/webgl/WebGLContextEvent.html
Comment 7 Sam Weinig 2011-09-01 11:19:44 PDT 
Committed r94319: <http://trac.webkit.org/changeset/94319>
Comment 8 James Robinson 2011-09-01 11:44:53 PDT 
(In reply to comment #6)
> (From update of attachment 105982 [details])
> Attachment 105982 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/9586082
> 
> New failing tests:
> fast/canvas/webgl/WebGLContextEvent.html

Unsurprisingly this is now failing on the actual waterfall.  Why did you land it if you knew it would make the tree red?  Do you have any pointers about what to do to fix this?