Bug 67332 - Fix compile issues when enabling HAVE(CFNETWORK_DATA_ARRAY_CALLBACK)
Summary: Fix compile issues when enabling HAVE(CFNETWORK_DATA_ARRAY_CALLBACK)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 16:07 PDT by Pratik Solanki
Modified: 2011-08-31 17:25 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2011-08-31 16:27 PDT, Pratik Solanki 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-08-31 16:07:19 PDT 
Recent changes (r93811 and  r94093) have broken compiles with HAVE(CFNETWORK_DATA_ARRAY_CALLBACK) enabled.
Comment 1 Pratik Solanki 2011-08-31 16:27:07 PDT 
Created attachment 105854 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-08-31 16:41:53 PDT 
Comment on attachment 105854 [details]
Patch

r=me as a build fix, but I don't understand the second change. How can we use CFNETWORK_DATA_ARRAY_CALLBACK when we don't use CFNETWORK? Something seems wrong.
Comment 3 Pratik Solanki 2011-08-31 17:20:22 PDT 
(In reply to comment #2)
> (From update of attachment 105854 [details])
> r=me as a build fix, but I don't understand the second change. How can we use CFNETWORK_DATA_ARRAY_CALLBACK when we don't use CFNETWORK? Something seems wrong.

CFNETWORK_DATA_ARRAY_CALLBACK can be used by the Foundation based loader as well. We have code for it in ResourceHandleMac.mm as well. Maybe we should change the name of the define to make it less confusing?
Comment 4 Pratik Solanki 2011-08-31 17:25:54 PDT 
Committed r94255: <http://trac.webkit.org/changeset/94255>