Bug 67330 - fix bug in flexbox test with offsetWidth/offsetLeft of 0
Summary: fix bug in flexbox test with offsetWidth/offsetLeft of 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 15:42 PDT by Ojan Vafai
Modified: 2011-08-31 16:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2011-08-31 15:43 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2011-08-31 15:51 PDT, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-08-31 15:42:42 PDT 
fix bug in flexbox test with offsetWidth/offsetLeft of 0
Comment 1 Ojan Vafai 2011-08-31 15:43:20 PDT 
Created attachment 105842 [details]
Patch
Comment 2 Ojan Vafai 2011-08-31 15:44:01 PDT 
Also remove the '<br>'. That wasn't working because we insert a text node. Not worth refactoring to make it work.
Comment 3 Tony Chang 2011-08-31 15:48:57 PDT 
Comment on attachment 105842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105842&action=review

> LayoutTests/css3/flexbox/resources/flexbox.js:17
> +    if (isDefined(node.offsetWidth) && expectedWidth) {

I think we can just drop the node.offsetWidth check.  This should still work if it's undefined.

> LayoutTests/css3/flexbox/resources/flexbox.js:23
> +    if (isDefined(node.offsetLeft) && expectedOffset) {

ditto
Comment 4 Ojan Vafai 2011-08-31 15:51:41 PDT 
Created attachment 105846 [details]
Patch
Comment 5 Ojan Vafai 2011-08-31 16:53:36 PDT 
Committed r94250: <http://trac.webkit.org/changeset/94250>