Bug 67316 - REGRESSION(92210): AVFoundation media engine is disabled on OS X
Summary: REGRESSION(92210): AVFoundation media engine is disabled on OS X
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Normal
Assignee: Jeff Miller
URL:
Keywords: InRadar
Depends on:
Blocks: 66253
  Show dependency tree / graph
 
Reported: 2011-08-31 14:05 PDT by Jeff Miller
Modified: 2011-08-31 16:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2011-08-31 16:36 PDT, Jeff Miller 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-08-31 14:05:08 PDT 
When I moved the definition of WTF_USE_AVFOUNDATION on the Mac from JavaScriptCore/wtf/Platform.h to WebCore/config.h to fix bug 65552, this caused AVFoundation to be disabled on OS X, since WebKit2 doesn't have access to WebCore/config.h on the Mac (it does on Windows).
Comment 1 Jeff Miller 2011-08-31 14:05:27 PDT 
<rdar://problem/10047199>
Comment 2 Jeff Miller 2011-08-31 14:20:06 PDT 
Sam says that we shouldn't have moved the definition of WTF_USE_AVFOUNDATION out of JavaScriptCore/wtf/Platform.h in the first place.  I'll use this bug to track fixing this for the Mac, and file a separate bug for Windows, since that's more involved.
Comment 3 Jeff Miller 2011-08-31 16:22:21 PDT 
Fixing this on Windows is tracked by bug 67334.
Comment 4 Jeff Miller 2011-08-31 16:36:17 PDT 
Created attachment 105857 [details]
Patch
Comment 5 Jeff Miller 2011-08-31 16:53:57 PDT 
Committed r94251: <http://trac.webkit.org/changeset/94251>