Bug 67309 - [Chromium] Rename WebKitClient to WebKitPlatformSupport
Summary: [Chromium] Rename WebKitClient to WebKitPlatformSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 11:59 PDT by Adam Barth
Modified: 2011-08-31 14:09 PDT (History)
3 users (show)

See Also:

Attachments
Work in progress (93.32 KB, patch)
2011-08-31 12:01 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (93.46 KB, patch)
2011-08-31 12:58 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (79.11 KB, patch)
2011-08-31 13:00 PDT, Adam Barth 		fishd: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-31 11:59:23 PDT 
[Chromium] Rename WebKitClient to WebKitPlatformSupport
Comment 1 Adam Barth 2011-08-31 12:01:36 PDT 
Created attachment 105807 [details]
Work in progress
Comment 2 Adam Barth 2011-08-31 12:58:37 PDT 
Created attachment 105816 [details]
Patch
Comment 3 Adam Barth 2011-08-31 12:59:10 PDT 
This patch depends on <http://codereview.chromium.org/7820001/>, so the EWS bot will fail.  I'll get that patch landed and rolling in before landing this patch.
Comment 4 Adam Barth 2011-08-31 13:00:52 PDT 
Created attachment 105817 [details]
Patch
Comment 5 WebKit Review Bot 2011-08-31 13:01:57 PDT 
Attachment 105816 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/public/WebKitPlatformSupport.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:116:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:183:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:218:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:249:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Review Bot 2011-08-31 13:03:13 PDT 
Attachment 105817 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/public/WebKitPlatformSupport.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:116:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:183:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:218:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebKitPlatformSupport.h:249:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2011-08-31 13:36:03 PDT 
Comment on attachment 105817 [details]
Patch

Attachment 105817 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9565888
Comment 8 Darin Fisher (:fishd, Google) 2011-08-31 13:38:39 PDT 
Comment on attachment 105817 [details]
Patch

Awesome!  Maybe we should also rename PlatformBridge to PlatformSupport :)
Comment 9 Adam Barth 2011-08-31 13:39:36 PDT 
> Maybe we should also rename PlatformBridge to PlatformSupport :)

Interesting idea.  I'll investigate after I get this patch fully landed.
Comment 10 Adam Barth 2011-08-31 14:09:34 PDT 
Committed r94231: <http://trac.webkit.org/changeset/94231>