RESOLVED FIXED 67309
[Chromium] Rename WebKitClient to WebKitPlatformSupport 
https://bugs.webkit.org/show_bug.cgi?id=67309
Summary [Chromium] Rename WebKitClient to WebKitPlatformSupport
Adam Barth
Reported 2011-08-31 11:59:23 PDT
[Chromium] Rename WebKitClient to WebKitPlatformSupport
Attachments
Work in progress (93.32 KB, patch)
2011-08-31 12:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (93.46 KB, patch)
2011-08-31 12:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (79.11 KB, patch)
2011-08-31 13:00 PDT, Adam Barth 		fishd: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-08-31 12:01:36 PDT
Created attachment 105807 [details] Work in progress
Adam Barth
Comment 2 2011-08-31 12:58:37 PDT
Created attachment 105816 [details] Patch
Adam Barth
Comment 3 2011-08-31 12:59:10 PDT
This patch depends on <http://codereview.chromium.org/7820001/>, so the EWS bot will fail. I'll get that patch landed and rolling in before landing this patch.
Adam Barth
Comment 4 2011-08-31 13:00:52 PDT
Created attachment 105817 [details] Patch
WebKit Review Bot
Comment 5 2011-08-31 13:01:57 PDT
Attachment 105816 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebKitPlatformSupport.h:42: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/public/WebKitPlatformSupport.h:116: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebKitPlatformSupport.h:183: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebKitPlatformSupport.h:218: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebKitPlatformSupport.h:249: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 5 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 6 2011-08-31 13:03:13 PDT
Attachment 105817 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebKitPlatformSupport.h:42: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/public/WebKitPlatformSupport.h:116: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebKitPlatformSupport.h:183: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebKitPlatformSupport.h:218: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebKitPlatformSupport.h:249: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 5 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7 2011-08-31 13:36:03 PDT
Comment on attachment 105817 [details] Patch Attachment 105817 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9565888
Darin Fisher (:fishd, Google)
Comment 8 2011-08-31 13:38:39 PDT
Comment on attachment 105817 [details] Patch Awesome! Maybe we should also rename PlatformBridge to PlatformSupport :)
Adam Barth
Comment 9 2011-08-31 13:39:36 PDT
> Maybe we should also rename PlatformBridge to PlatformSupport :) Interesting idea. I'll investigate after I get this patch fully landed.
Adam Barth
Comment 10 2011-08-31 14:09:34 PDT
Committed r94231: <http://trac.webkit.org/changeset/94231>
Note You need to log in before you can comment on or make changes to this bug.