Bug 67304 – Web Inspector: [Chromium] Perform a more effective JS GC

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

We shouldn't require user to push the "GC" button several times.

[Mikhail Naganov]

Created attachment 105799 [details]
Patch

[Pavel Feldman]

Comment on attachment 105799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105799&action=review

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:65
> +    while (!v8::V8::IdleNotification()) {

should be { }. I'd like somebody from v8 team to bless this change before I rubber stamp it.

[Mikhail Naganov]

Created attachment 105941 [details]
Comments addressed

Fixed braces.

I've found this code in Chromium's ChromeRenderProcessObserver::OnPurgeMemory. I've discussed it with Slava from the V8 team, and we have agreed that this approach is more effective because it actually does several rounds of GC, clears compilation caches and other stuff that will be left intact after a single MC GC round.

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/94322

2011-08-31  Mikhail Naganov  <[e-mail]>

        Web Inspector: [Chromium] Perform a more effective JS GC
        https://bugs.webkit.org/show_bug.cgi?id=67304

        Reviewed by Pavel Feldman.

        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::collectGarbage):

[Ulan Degenbaev]

Created attachment 114070 [details]
LowMemoryNotification instead of IdleNotification

The new GC fixes the LowMemoryNofication, so now there is no need to repeatedly call the IdleNotification.

[Pavel Feldman]

Comment on attachment 114070 [details]
LowMemoryNotification instead of IdleNotification

Please file a separate bug for each patch. Use webkit.org/new-inspector-bug as a template.

[Mikhail Naganov]

I'd also wait for several days before committing this change to make sure that the new V8 version sticks in Chromium, as it has been already rolled out several times due to performance regressions on bots.