Bug 67294 – Web Inspector: speed-up Network panel

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

Network panel's rendering speed is slow.
It is about 6 sec when the panel has 700 requests.

[Ilya Tikhonovsky]

Created attachment 105779 [details]
[patch] initial version


        Network panel's rendering speed is slow.
        It is about 6 sec when the panel has 700 requests.
        I found that:
        1) WebInspector.NetworkLogView._updateOffscreenRows is completely unnecessary;
        2) window.resize events fired two times per single resize;
        3) DataGrid.updateWidth is calling from refresh method but it is unnecessary;
        4) some time expensive operations are calling even if they are not necessary.

[Pavel Feldman]

(In reply to comment #1)
> Created an attachment (id=105779) [details]
> [patch] initial version
> 
> 
>         Network panel's rendering speed is slow.
>         It is about 6 sec when the panel has 700 requests.
>         I found that:
>         1) WebInspector.NetworkLogView._updateOffscreenRows is completely unnecessary;

It used to remove cell contents from render tree and speed up network panel appearance significantly. I think you are regressing it.

>         2) window.resize events fired two times per single resize;
>         3) DataGrid.updateWidth is calling from refresh method but it is unnecessary;

It is needed for updating column widths when scroller appears.

>         4) some time expensive operations are calling even if they are not necessary.

At least some of these statements are false. Please review with caution. Likely introduces multiple regressions.

[Pavel Feldman]

Comment on attachment 105779 [details]
[patch] initial version

What scenarios take 6 seconds for you? Update offscreen rows should make render tree bare and speed things up. Try filling the pane with 700 requests and switching between panels (Network->Audits->Network). You will notice that your change regresses this scenario significantly.

[Brian Burg]

Maybe a better approach is to make DataGrid scale better. Has anyone looked at reimplementing it, with an eye towards SlickGrid's implementation strategy? (obviously w/o the bells and whistles) 

Are there any fundamental complications? It seems their approach can allow for trees. (http://mleibman.github.com/SlickGrid/examples/example5-collapsing.html)