Bug 67289 - Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.
Summary: Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 07:28 PDT by asvitkine
Modified: 2011-08-31 14:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.89 KB, patch)
2011-08-31 07:30 PDT, asvitkine
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description asvitkine 2011-08-31 07:28:08 PDT
Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.
Comment 1 asvitkine 2011-08-31 07:30:30 PDT
Created attachment 105775 [details]
Patch
Comment 2 Nico Weber 2011-08-31 07:59:07 PDT
Comment on attachment 105775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105775&action=review

LGTM

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:783
> +        shadowRect.setHeight(kShadowSize);

I guess the reason you have two calls for the toolbar gradient is because the vertical overhang shadow is always full-height while the horizontal overhang shadow might be smaller.

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:791
>      // If both rectangles present, draw a radial gradient for the corner.

I assume you checked that it doesn't look weird that this gets drawn on top of the toolbar shadow :-)
Comment 3 asvitkine 2011-08-31 08:11:59 PDT
> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:783
> > +        shadowRect.setHeight(kShadowSize);
> 
> I guess the reason you have two calls for the toolbar gradient is because the vertical overhang shadow is always full-height while the horizontal overhang shadow might be smaller.

Correct.

> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:791
> >      // If both rectangles present, draw a radial gradient for the corner.
> 
> I assume you checked that it doesn't look weird that this gets drawn on top of the toolbar shadow :-)

When there's a vertical overhang, the implementation degrades to using additive shadows since it's not really possible to have non-additive shadows in the presence of the corner radial gradient. 

So when the radial gradient is shown, it implies there's a vertical overhang and thus we use additive shadows - so it looks consistent with the horizontal overhang shadows which will also be additive in that case.
Comment 4 WebKit Review Bot 2011-08-31 14:23:56 PDT
Comment on attachment 105775 [details]
Patch

Clearing flags on attachment: 105775

Committed r94234: <http://trac.webkit.org/changeset/94234>
Comment 5 WebKit Review Bot 2011-08-31 14:24:01 PDT
All reviewed patches have been landed.  Closing bug.