Bug 67278 – Web Inspector: Having the "Metrics" pane open affects the node highlight display

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

1. Open Web Inspector, open the Elements pane.
2. Start iterating over nodes using keyboard (Up and Down arrows). Notice how the current node is highlighted.
3. Now expand the Metrics pane and try to do the same.

The blue rectangle only blinks for a moment. It is expected that it should work the same regardless of the "Metrics" pane state.

[Alexander Pavlov (apavlov)]

Upstreaming http://crbug.com/93751

[Alexander Pavlov (apavlov)]

Created attachment 105769 [details]
[PATCH] Suggested fix

[Yury Semikhatsky]

Comment on attachment 105769 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=105769&action=review

> Source/WebCore/inspector/front-end/MetricsSidebarPane.js:265
> +            boxElement.addEventListener("mouseover", this._highlightDOMNode.bind(this, true, name === "position" ? "" : name), false);

Could you pass "all" instead of "" for clarity?

[Alexander Pavlov (apavlov)]

(In reply to comment #3)
> (From update of attachment 105769 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105769&action=review
> 
> > Source/WebCore/inspector/front-end/MetricsSidebarPane.js:265
> > +            boxElement.addEventListener("mouseover", this._highlightDOMNode.bind(this, true, name === "position" ? "" : name), false);
> 
> Could you pass "all" instead of "" for clarity?

Will fix.

[Alexander Pavlov (apavlov)]

Committed r94181: <http://trac.webkit.org/changeset/94181>

[Alexander Pavlov (apavlov)]

*** Bug 66928 has been marked as a duplicate of this bug. ***