Add all ICU languages to LocaleToScriptMappingDefault.cpp

[Matt Falkenhagen]

Expand the hard-coded mapping of locales to script in LocaleToScriptMappingDefault.cpp (see comments on bug 10874).

[Matt Falkenhagen]

Created attachment 105762 [details]
Patch

[Kent Tamura]

Comment on attachment 105762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105762&action=review

> Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp:157
> +        for (size_t i = 0; i < sizeof(scriptNameCodeList) / sizeof(scriptNameCodeList[0]); ++i)

You can use WTF_ARRAY_LENGTH(scriptNameCodeList) in wtf/StdLibExtras.h.

[Eric Seidel (no email)]

Comment on attachment 105762 [details]
Patch

seems reasonable to me.  ap or jungshik know the most about ICU in WebCore.  Post a new patch using the ARRAY_SIZE macro and I'm ready to r+ this.

[Alexey Proskuryakov]

Comment on attachment 105762 [details]
Patch

Yes, looks reasonable.

[Matt Falkenhagen]

I get an error:

no matching function for call to ‘ArrayLengthHelperFunction(const WebCore::getScriptCode(const WTF::St
ring&)::ScriptNameCode [104])’

for WTF_ARRAY_LENGTH(scriptNameCodeList). I think maybe it can't be used on arrays of local structs. I could get it to work on an array of ints.

I'll upload a new patch soon that just makes scriptNameCodeList const.

[Matt Falkenhagen]

Created attachment 120145 [details]
add const

[Kent Tamura]

Comment on attachment 120145 [details]
add const

ok

[WebKit Review Bot]

Comment on attachment 120145 [details]
add const

Clearing flags on attachment: 120145

Committed r103397: <http://trac.webkit.org/changeset/103397>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.