Bug 67271 - Rename colorSelected to didChooseColor
Summary: Rename colorSelected to didChooseColor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 01:20 PDT by Keishi Hattori
Modified: 2011-09-01 00:39 PDT (History)
2 users (show)

See Also:


Attachments
patch (4.13 KB, patch)
2011-08-31 23:18 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
changed changelog (4.08 KB, patch)
2011-08-31 23:34 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2011-08-31 01:20:30 PDT
Rename colorSelected to didChooseColor to match the WebKit Chromium API discussed in Bug 65897
Comment 1 Keishi Hattori 2011-08-31 01:22:17 PDT
Will be uploading patch when Bug 67270 lands
Comment 2 Keishi Hattori 2011-08-31 23:18:32 PDT
Created attachment 105898 [details]
patch
Comment 3 Kent Tamura 2011-08-31 23:24:27 PDT
Comment on attachment 105898 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105898&action=review

r- because ChangeLog is not reasonable.

> Source/WebCore/ChangeLog:11
> +        (WebCore::ColorInputType::didChooseColor): Renamed colorSelected to didChooseColor. Chromium WebKit API
> +        will be using didChooseColor and so this will match that.

In this case, the name in Chromium API won't be a reason to change WebCore.
Anyway, didSomething() is common in WebCore.  So I think this change is reasonable.
Comment 4 Keishi Hattori 2011-08-31 23:34:30 PDT
Created attachment 105902 [details]
changed changelog
Comment 5 Kent Tamura 2011-08-31 23:35:52 PDT
Comment on attachment 105902 [details]
changed changelog

ok
Comment 6 WebKit Review Bot 2011-09-01 00:39:09 PDT
Comment on attachment 105902 [details]
changed changelog

Clearing flags on attachment: 105902

Committed r94279: <http://trac.webkit.org/changeset/94279>
Comment 7 WebKit Review Bot 2011-09-01 00:39:13 PDT
All reviewed patches have been landed.  Closing bug.