RESOLVED FIXED 67271
Rename colorSelected to didChooseColor 
https://bugs.webkit.org/show_bug.cgi?id=67271
Summary Rename colorSelected to didChooseColor
Keishi Hattori
Reported 2011-08-31 01:20:30 PDT
Rename colorSelected to didChooseColor to match the WebKit Chromium API discussed in Bug 65897
Attachments
patch (4.13 KB, patch)
2011-08-31 23:18 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
changed changelog (4.08 KB, patch)
2011-08-31 23:34 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2011-08-31 01:22:17 PDT
Will be uploading patch when Bug 67270 lands
Keishi Hattori
Comment 2 2011-08-31 23:18:32 PDT
Created attachment 105898 [details] patch
Kent Tamura
Comment 3 2011-08-31 23:24:27 PDT
Comment on attachment 105898 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=105898&action=review r- because ChangeLog is not reasonable. > Source/WebCore/ChangeLog:11 > + (WebCore::ColorInputType::didChooseColor): Renamed colorSelected to didChooseColor. Chromium WebKit API > + will be using didChooseColor and so this will match that. In this case, the name in Chromium API won't be a reason to change WebCore. Anyway, didSomething() is common in WebCore. So I think this change is reasonable.
Keishi Hattori
Comment 4 2011-08-31 23:34:30 PDT
Created attachment 105902 [details] changed changelog
Kent Tamura
Comment 5 2011-08-31 23:35:52 PDT
Comment on attachment 105902 [details] changed changelog ok
WebKit Review Bot
Comment 6 2011-09-01 00:39:09 PDT
Comment on attachment 105902 [details] changed changelog Clearing flags on attachment: 105902 Committed r94279: <http://trac.webkit.org/changeset/94279>
WebKit Review Bot
Comment 7 2011-09-01 00:39:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.