Bug 67256 - [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
Summary: [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks: 67239
  Show dependency treegraph
 
Reported: 2011-08-30 20:28 PDT by Jarred Nicholls
Modified: 2011-12-03 03:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.26 KB, patch)
2011-12-02 17:18 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jarred Nicholls 2011-08-30 20:28:32 PDT
Gtk DRT should translate file:///tmp/LayoutTests paths into a local URL that's derived from the path of the DRT application exec.
Comment 1 Martin Robinson 2011-08-31 22:55:11 PDT
Which tests are failing because of this issue?
Comment 2 Jarred Nicholls 2011-08-31 23:28:40 PDT
Any tests that run in NRWT which load a local resource from /tmp/LayoutTests.

e.g.
fast/dom/frame-loading-via-document-write.html
fast/loader/local-CSS-from-local.html
fast/loader/local-JavaScript-from-local.html
fast/loader/local-image-from-local.html
http/tests/security/local-user-CSS-from-remote.html

see bug #67254 for Qt's implementation.
Chromium's implementation and related logic: http://pastie.org/2464106

original bug #64135
Comment 3 Martin Robinson 2011-12-02 17:18:03 PST
Created attachment 117715 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-02 17:21:22 PST
Attachment 117715 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/g..." exit_code: 1

Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:91:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Philippe Normand 2011-12-03 02:13:57 PST
Comment on attachment 117715 [details]
Patch

This is neat!
Comment 6 WebKit Review Bot 2011-12-03 03:33:21 PST
Comment on attachment 117715 [details]
Patch

Clearing flags on attachment: 117715

Committed r101922: <http://trac.webkit.org/changeset/101922>
Comment 7 WebKit Review Bot 2011-12-03 03:33:25 PST
All reviewed patches have been landed.  Closing bug.