Improve appearance and performance of layout test results.html

[Simon Fraser (smfr)]

fast/harness/results.html, which is used to display test results, has really poor behavior when viewing the zoomed pixel diffs on Mac. It's also very ugly.

[Simon Fraser (smfr)]

Created attachment 105728 [details]
New look with the coming patch

[Dimitri Glazkov (Google)]

Woot! smfr got a tools bug! :P

[Simon Fraser (smfr)]

Created attachment 105729 [details]
Patch

[Adam Barth]

Comment on attachment 105729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105729&action=review

Ojan should really review this patch.

> LayoutTests/fast/harness/results.html:749
> -    container.innerHTML = '<div class=label>' + title + '</div><canvas></canvas>';    
> +    container.innerHTML = '<div class="label">' + title + '</div><div class="scaled-image-container"><img src="' + url + '"></div>';    

XSS sad face

[Adam Barth]

Comment on attachment 105729 [details]
Patch

rs=me.  Please feel encouraged to run this by Ojan before landing.

[Ojan Vafai]

Comment on attachment 105729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105729&action=review

Code looks fine. Thanks for improving this. I'm not too familiar with -webkit-optimize-contrast, does it not anti-alias the zoomed image? That was the only reason I used canvas.

> LayoutTests/fast/harness/results.html:790
> +    var image = imageContainer.firstChild;

Nit: For future robustness I'd rather use imageContainer.querySelector('img').

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/94212