RESOLVED FIXED 67252
Improve appearance and performance of layout test results.html 
https://bugs.webkit.org/show_bug.cgi?id=67252
Summary Improve appearance and performance of layout test results.html
Simon Fraser (smfr)
Reported 2011-08-30 19:03:00 PDT
fast/harness/results.html, which is used to display test results, has really poor behavior when viewing the zoomed pixel diffs on Mac. It's also very ugly.
Attachments
New look with the coming patch (102.44 KB, image/png)
2011-08-30 19:03 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (5.78 KB, patch)
2011-08-30 19:06 PDT, Simon Fraser (smfr) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-08-30 19:03:22 PDT
Created attachment 105728 [details] New look with the coming patch
Dimitri Glazkov (Google)
Comment 2 2011-08-30 19:06:01 PDT
Woot! smfr got a tools bug! :P
Simon Fraser (smfr)
Comment 3 2011-08-30 19:06:47 PDT
Created attachment 105729 [details] Patch
Adam Barth
Comment 4 2011-08-30 22:27:16 PDT
Comment on attachment 105729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105729&action=review Ojan should really review this patch. > LayoutTests/fast/harness/results.html:749 > - container.innerHTML = '<div class=label>' + title + '</div><canvas></canvas>'; > + container.innerHTML = '<div class="label">' + title + '</div><div class="scaled-image-container"><img src="' + url + '"></div>'; XSS sad face
Adam Barth
Comment 5 2011-08-30 22:28:05 PDT
Comment on attachment 105729 [details] Patch rs=me. Please feel encouraged to run this by Ojan before landing.
Ojan Vafai
Comment 6 2011-08-31 08:49:51 PDT
Comment on attachment 105729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105729&action=review Code looks fine. Thanks for improving this. I'm not too familiar with -webkit-optimize-contrast, does it not anti-alias the zoomed image? That was the only reason I used canvas. > LayoutTests/fast/harness/results.html:790 > + var image = imageContainer.firstChild; Nit: For future robustness I'd rather use imageContainer.querySelector('img').
Simon Fraser (smfr)
Comment 7 2011-08-31 11:57:03 PDT
http://trac.webkit.org/changeset/94212
Note You need to log in before you can comment on or make changes to this bug.