Bug 67243 - add a test for border/padding/margin on the flexbox container
Summary: add a test for border/padding/margin on the flexbox container
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 16:00 PDT by Ojan Vafai
Modified: 2011-08-30 17:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2011-08-30 16:01 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-08-30 16:00:42 PDT 
add a test for border/padding/margin on the flexbox container
Comment 1 Ojan Vafai 2011-08-30 16:01:08 PDT 
Created attachment 105714 [details]
Patch
Comment 2 Tony Chang 2011-08-30 16:16:03 PDT 
Comment on attachment 105714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105714&action=review

I like more tests.

> LayoutTests/css3/flexbox/001.html:146
> +    <div data-expected-width="700" style="display: -webkit-flexbox; padding-left: 10px; padding-right: 20px; border-left: 30px solid; border-right: 40px solid; margin-left: 50px; margin-right:60px;" class="horizontal-box ">

Can we drop the display: property?
Comment 3 WebKit Review Bot 2011-08-30 17:28:52 PDT 
Comment on attachment 105714 [details]
Patch

Clearing flags on attachment: 105714

Committed r94137: <http://trac.webkit.org/changeset/94137>
Comment 4 WebKit Review Bot 2011-08-30 17:28:56 PDT 
All reviewed patches have been landed.  Closing bug.