RESOLVED WONTFIX 67226
Plug-ins have no way to find out when the device scale factor changes 
https://bugs.webkit.org/show_bug.cgi?id=67226
Summary Plug-ins have no way to find out when the device scale factor changes
Adam Roben (:aroben)
Reported 2011-08-30 13:49:20 PDT
Plug-ins need to be able to tell when the device scale factor changes so they can (e.g.) load different-resolution art and draw it. But currently they have no way to find this out. We should add an NPAPI-style API to notify them.
Attachments
Patch (21.97 KB, patch)
2011-10-25 16:41 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-08-30 13:49:39 PDT
<rdar://problem/10048276>
Anders Carlsson
Comment 2 2011-10-25 16:41:49 PDT
Created attachment 112428 [details] Patch
Anders Carlsson
Comment 3 2011-10-25 17:29:41 PDT
Committed r98413: <http://trac.webkit.org/changeset/98413>
Csaba Osztrogonác
Comment 4 2011-10-25 23:25:45 PDT
It broke the GTK build. Reopen to fix the build. ../../Source/WebKit2/PluginProcess/PluginControllerProxy.cpp: In member function ‘void WebKit::PluginControllerProxy::geometryDidChange(const WebCore::IntRect&, const WebCore::IntRect&, float, const WebKit::ShareableBitmap::Handle&)’: ../../Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:433:32: error: ‘m_contentsScaleFactor’ was not declared in this scope ../../Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:435:19: error: ‘class WebKit::Plugin’ has no member named ‘contentsScaleFactorChanged’
Ryosuke Niwa
Comment 5 2011-10-26 00:01:38 PDT
GTK build fixes attempted in http://trac.webkit.org/changeset/98435 and http://trac.webkit.org/changeset/98437.
Ryosuke Niwa
Comment 6 2011-10-26 00:41:07 PDT
GTK build fixed in http://trac.webkit.org/changeset/98438.
Martin Robinson
Comment 7 2011-10-26 00:51:29 PDT
(In reply to comment #6) > GTK build fixed in http://trac.webkit.org/changeset/98438. Thank you!
Ahmad Saleem
Comment 8 2022-06-22 13:27:39 PDT
NPAPI support is removed from Safari 14 onward and it is not supported in Webkit Builds like WebkitGTK as well. I think this can be marked as "RESOLVED WONTFIX". Thanks!
Ryosuke Niwa
Comment 9 2022-06-22 22:22:00 PDT
Yup, won't fix.
Note You need to log in before you can comment on or make changes to this bug.