Bug 67226 - Plug-ins have no way to find out when the device scale factor changes
Summary: Plug-ins have no way to find out when the device scale factor changes
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.7
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-08-30 13:49 PDT by Adam Roben (:aroben)
Modified: 2022-06-22 22:22 PDT (History)
11 users (show)

See Also:

Attachments
Patch (21.97 KB, patch)
2011-10-25 16:41 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-08-30 13:49:20 PDT 
Plug-ins need to be able to tell when the device scale factor changes so they can (e.g.) load different-resolution art and draw it. But currently they have no way to find this out. We should add an NPAPI-style API to notify them.
Comment 1 Radar WebKit Bug Importer 2011-08-30 13:49:39 PDT 
<rdar://problem/10048276>
Comment 2 Anders Carlsson 2011-10-25 16:41:49 PDT 
Created attachment 112428 [details]
Patch
Comment 3 Anders Carlsson 2011-10-25 17:29:41 PDT 
Committed r98413: <http://trac.webkit.org/changeset/98413>
Comment 4 Csaba Osztrogonác 2011-10-25 23:25:45 PDT 
It broke the GTK build. Reopen to fix the build.

../../Source/WebKit2/PluginProcess/PluginControllerProxy.cpp: In member function ‘void WebKit::PluginControllerProxy::geometryDidChange(const WebCore::IntRect&, const WebCore::IntRect&, float, const WebKit::ShareableBitmap::Handle&)’:
../../Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:433:32: error: ‘m_contentsScaleFactor’ was not declared in this scope
../../Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:435:19: error: ‘class WebKit::Plugin’ has no member named ‘contentsScaleFactorChanged’
Comment 5 Ryosuke Niwa 2011-10-26 00:01:38 PDT 
GTK build fixes attempted in http://trac.webkit.org/changeset/98435 and http://trac.webkit.org/changeset/98437.
Comment 6 Ryosuke Niwa 2011-10-26 00:41:07 PDT 
GTK build fixed in http://trac.webkit.org/changeset/98438.
Comment 7 Martin Robinson 2011-10-26 00:51:29 PDT 
(In reply to comment #6)
> GTK build fixed in http://trac.webkit.org/changeset/98438.

Thank you!
Comment 8 Ahmad Saleem 2022-06-22 13:27:39 PDT 
NPAPI support is removed from Safari 14 onward and it is not supported in Webkit Builds like WebkitGTK as well. I think this can be marked as "RESOLVED WONTFIX". Thanks!
Comment 9 Ryosuke Niwa 2022-06-22 22:22:00 PDT 
Yup, won't fix.