RESOLVED FIXED 67223
shouldBeEqualToString should encode special characters 
https://bugs.webkit.org/show_bug.cgi?id=67223
Summary shouldBeEqualToString should encode special characters
Erik Arvidsson
Reported 2011-08-30 12:57:38 PDT
shouldBeEqualToString should encode special characters
Attachments
Patch (2.13 KB, patch)
2011-08-30 13:00 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2011-08-30 13:00:51 PDT
Created attachment 105676 [details] Patch
Alexey Proskuryakov
Comment 2 2011-08-31 15:03:02 PDT
This patch has no rationale. Why?
Alexey Proskuryakov
Comment 3 2011-08-31 15:03:28 PDT
*** Bug 67222 has been marked as a duplicate of this bug. ***
Erik Arvidsson
Comment 4 2011-08-31 15:21:03 PDT
I was looking at the code and found the NOOP replace; b.replace(/"/g, "\"") does nothing. My initial plan was to just to remove the call to replace but after seeing that other places does encode the string correctly I was convinced that the encoding is needed.
Darin Adler
Comment 5 2011-08-31 16:31:28 PDT
Comment on attachment 105676 [details] Patch Does this change affect any test results?
Erik Arvidsson
Comment 6 2011-08-31 16:47:11 PDT
(In reply to comment #5) > (From update of attachment 105676 [details]) > Does this change affect any test results? No, no tests depends on these at the moment. I ran into the issue because I wanted to use shouldBeEqualToString in some new tests.
WebKit Review Bot
Comment 7 2011-08-31 18:21:29 PDT
Comment on attachment 105676 [details] Patch Clearing flags on attachment: 105676 Committed r94260: <http://trac.webkit.org/changeset/94260>
WebKit Review Bot
Comment 8 2011-08-31 18:21:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.