Get rid of platform specific undefs for NO_ERROR and VERSION in GraphicsContext3D
Created attachment 105649 [details] Patch
Comment on attachment 105649 [details] Patch Attachment 105649 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9572270
Comment on attachment 105649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105649&action=review This fails to compile. See the Qt EWS build failure. It’s because the IDL and C++ names need to match. To change the names we’d probably need a new feature in the bindings generation script. > Source/WebCore/html/canvas/WebGLRenderingContext.idl:145 > - const unsigned int NO_ERROR = 0; > + const unsigned int NO_ERROR = 0; // This is named GC3D_NO_ERROR in GraphicsContext3D to avoid clash with system defines on some platforms I’m not sure this comment is helpful here. Don’t we have something in the IDL-generation process that requires that the C++ constant and the IDL constant have the same name and same value? I had thought we did, and I’m surprised you are not having problems compiling. > Source/WebCore/html/canvas/WebGLRenderingContext.idl:288 > - const unsigned int VERSION = 0x1F02; > + const unsigned int VERSION = 0x1F02; // This is named GC3D_VERSION in GraphicsContext3D to avoid clash with system defines on some platforms Ditto.