WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
67207
[skia] antialias images if we're rotated
https://bugs.webkit.org/show_bug.cgi?id=67207
Summary
[skia] antialias images if we're rotated
Mike Reed
Reported
2011-08-30 10:06:29 PDT
[skia] antialias images if we're rotated
Attachments
Patch
(4.76 KB, patch)
2011-08-30 10:08 PDT
,
Mike Reed
no flags
Details
Formatted Diff
Diff
Patch
(3.42 KB, patch)
2011-08-30 10:09 PDT
,
Mike Reed
no flags
Details
Formatted Diff
Diff
Patch
(3.30 KB, patch)
2011-08-30 10:46 PDT
,
Mike Reed
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Mike Reed
Comment 1
2011-08-30 10:08:39 PDT
Created
attachment 105645
[details]
Patch
Mike Reed
Comment 2
2011-08-30 10:09:54 PDT
Created
attachment 105646
[details]
Patch
Stephen White
Comment 3
2011-08-30 10:21:10 PDT
Comment on
attachment 105646
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=105646&action=review
Looks good, but I'm gonna let the EWS bots chew on it a bit.
> Source/WebCore/ChangeLog:10 > + * platform/graphics/skia/ImageBufferSkia.cpp: > + (WebCore::getImageData): > + (WebCore::putImageData):
Nit: Looks like this file was reverted; could probably remove these lines from the ChangeLog.
Mike Reed
Comment 4
2011-08-30 10:46:01 PDT
Created
attachment 105651
[details]
Patch
Mike Reed
Comment 5
2011-08-30 10:46:21 PDT
removed reverted change from ChangeLog
Stephen White
Comment 6
2011-08-30 11:08:44 PDT
Comment on
attachment 105651
[details]
Patch Looks good (as long as the bots are ok with it). r=me
Mike Reed
Comment 7
2011-08-30 13:53:23 PDT
cr-linux failures are unrelated I think. Will retry tomorrow.
WebKit Review Bot
Comment 8
2011-08-31 07:03:29 PDT
Comment on
attachment 105651
[details]
Patch Clearing flags on attachment: 105651 Committed
r94185
: <
http://trac.webkit.org/changeset/94185
>
WebKit Review Bot
Comment 9
2011-08-31 07:03:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug