Web Inspector: implement source map v3 consumer.
Created attachment 105640 [details] Patch
Format spec: https://docs.google.com/a/chromium.org/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit?hl=en_US
Comment on attachment 105640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105640&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:49 > + get sources() This should be a function since it may be overridden. > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:59 > +WebInspector.ClosureCompilerSourceMapping = function(payload) Is there a document describing the mapping format? If so, please add a link to the document here, otherwise provide a description of the format. > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:101 > + count -= step; Can we replace count with step in the loop and get rid of these "count =" assignments?
Created attachment 106346 [details] Patch
(In reply to comment #3) > (From update of attachment 105640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105640&action=review > > > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:49 > > + get sources() > > This should be a function since it may be overridden. I think getters/setters can also be overridden just like regular functions. > > > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:59 > > +WebInspector.ClosureCompilerSourceMapping = function(payload) > > Is there a document describing the mapping format? If so, please add a link to the document here, otherwise provide a description of the format. Done. > > > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:101 > > + count -= step; > > Can we replace count with step in the loop and get rid of these "count =" assignments? I don't think so, both count and step are required here since count could be odd.
Comment on attachment 106346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106346&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:61 > + // This class implements Source Map V3 consumer. Source Map V3 format is described The comment should go into the constructor description, not in its body.
Committed r94577: <http://trac.webkit.org/changeset/94577>