Bug 67193 - Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
Summary: Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::di...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 03:39 PDT by Vsevolod Vlasov
Modified: 2011-08-30 08:27 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2011-08-30 04:29 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2011-08-30 07:26 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-08-30 03:39:44 PDT
Chromium crash report: http://code.google.com/p/chromium/issues/detail?id=93469
Comment 1 Vsevolod Vlasov 2011-08-30 04:29:37 PDT
Created attachment 105613 [details]
Patch
Comment 2 Yury Semikhatsky 2011-08-30 06:41:53 PDT
Comment on attachment 105613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105613&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> +    if (!loader || !loader->frame())

All this check should be in if (m_resourcesData->resourceType(requestId) == InspectorPageAgent::DocumentResource), shouldn't them?
Comment 3 Vsevolod Vlasov 2011-08-30 07:26:30 PDT
Created attachment 105624 [details]
Patch
Comment 4 Vsevolod Vlasov 2011-08-30 08:27:55 PDT
Committed r94078: <http://trac.webkit.org/changeset/94078>