Bug 67181 – REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

http://code.google.com/p/chromium/issues/detail?id=94602

[Kent Tamura]

Created attachment 105587 [details]
Patch

[WebKit Review Bot]

Attachment 105587 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

ERROR: FAILURES FOR <lucid, x86_64, release, cpu>
ERROR: Line:3483 Path does not exist. fast/forms/file/file-appearnace.html
LayoutTests/platform/chromium/test_expectations.txt:3483:  Path does not exist. fast/forms/file/file-appearnace.html  [test/expectations] [2]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kent Tamura]

Created attachment 105590 [details]
Patch 2

Add a missing file

[Darin Adler]

Comment on attachment 105590 [details]
Patch 2

Is the font-size the only thing we want to inherit? What about other style properties?

[Kent Tamura]

(In reply to comment #4)
> (From update of attachment 105590 [details])
> Is the font-size the only thing we want to inherit? What about other style properties?

As you see on the second file upload control in file-appearance-expected.png, 'color' property of input[type=file] should be 'inherit.'  But I think it's a very old bug, not a regression by r88115.
I have no other ideas of other properties.

[Kent Tamura]

(In reply to comment #5)
> As you see on the second file upload control in file-appearance-expected.png, 'color' property of input[type=file] should be 'inherit.'  But I think it's a very old bug, not a regression by r88115.

I'll fix color issue by another patch.

[Dimitri Glazkov (Google)]

Comment on attachment 105590 [details]
Patch 2

can the test be made dump-as-text? You can read shadowRoot using window.internals, then read its computed style.

[Kent Tamura]

Created attachment 105886 [details]
Patch for landing

Convert the test to dumpAsText

[WebKit Review Bot]

Comment on attachment 105886 [details]
Patch for landing

Clearing flags on attachment: 105886

Committed r94268: <http://trac.webkit.org/changeset/94268>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.