Bug 67180 – WebSocket: Receive binary message as ArrayBuffer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Yuta Kitamura]

Part of bug 65249. See also: bug 67115 (Receive binary message as Blob)

[Yuta Kitamura]

Created attachment 105585 [details]
Patch

[Kent Tamura]

Comment on attachment 105585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105585&action=review

> LayoutTests/http/tests/websocket/tests/hybi/receive-arraybuffer.html:32
> +// Create an ArrayBuffer containing all distinct bytes ("\x00" to "\xFF").
> +function createAllBytesValue()

nit: The comment is not so helpful because the function code is simple, and we can rename it to "createArrayBufferContainingAllDistinctBytes"

> LayoutTests/http/tests/websocket/tests/hybi/workers/resources/receive-arraybuffer.js:16
> +// Create an ArrayBuffer containing all distinct bytes ("\x00" to "\xFF").
> +function createAllBytesValue()

ditto.

> Source/WebCore/websockets/WebSocket.cpp:419
> +        RefPtr<ArrayBuffer> arrayBuffer = ArrayBuffer::create(binaryData->data(), binaryData->size());
> +        dispatchEvent(MessageEvent::create(arrayBuffer.release()));

The variable 'arrayBuffer' is not needed.

[Yuta Kitamura]

Created attachment 105618 [details]
Patch v2

[Yuta Kitamura]

Comment on attachment 105585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105585&action=review

>> LayoutTests/http/tests/websocket/tests/hybi/receive-arraybuffer.html:32
>> +function createAllBytesValue()
> 
> nit: The comment is not so helpful because the function code is simple, and we can rename it to "createArrayBufferContainingAllDistinctBytes"

Fixed. Updated function names in receive-blob.html too.

>> LayoutTests/http/tests/websocket/tests/hybi/workers/resources/receive-arraybuffer.js:16
>> +function createAllBytesValue()
> 
> ditto.

Fixed.

>> Source/WebCore/websockets/WebSocket.cpp:419
>> +        dispatchEvent(MessageEvent::create(arrayBuffer.release()));
> 
> The variable 'arrayBuffer' is not needed.

Fixed.

[Kent Tamura]

Comment on attachment 105618 [details]
Patch v2

Looks ok.

[WebKit Review Bot]

Comment on attachment 105618 [details]
Patch v2

Clearing flags on attachment: 105618

Committed r94161: <http://trac.webkit.org/changeset/94161>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.