RESOLVED FIXED 67169
[chromium] DumpRenderTree should be explicit about its dependency on GoogleURL 
https://bugs.webkit.org/show_bug.cgi?id=67169
Summary [chromium] DumpRenderTree should be explicit about its dependency on GoogleURL
Darin Fisher (:fishd, Google)
Reported 2011-08-29 17:01:45 PDT
[chromium] DumpRenderTree should be explicit about its dependency on GoogleURL DumpRenderTree uses GoogleURL code directly, and it should be explicit about that instead of picking up this dependency transitively, which only works for the static build. This is needed to support the "component" build of DumpRenderTree, in which the various Chromium dependencies are built as separate DLLs.
Attachments
v1 patch (1.60 KB, patch)
2011-08-29 17:03 PDT, Darin Fisher (:fishd, Google) 		rniwa: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2011-08-29 17:03:11 PDT
Created attachment 105548 [details] v1 patch
WebKit Review Bot
Comment 2 2011-08-30 01:44:47 PDT
Comment on attachment 105548 [details] v1 patch Rejecting attachment 105548 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: Updating working directory Processing patch 105548 from bug 67169. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9558538
Darin Fisher (:fishd, Google)
Comment 3 2011-08-30 12:25:21 PDT
Landed as http://trac.webkit.org/changeset/94096 with fixed up reviewer line.
Note You need to log in before you can comment on or make changes to this bug.