Bug 67161 - querySelector/querySelectorAll should use selector checker fast path
Summary: querySelector/querySelectorAll should use selector checker fast path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 16:04 PDT by Antti Koivisto
Modified: 2011-10-11 22:04 PDT (History)
5 users (show)

See Also:

Attachments
patch, missing non-Mac build files (29.95 KB, patch)
2011-08-29 16:38 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (34.65 KB, patch)
2011-08-30 02:42 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
updated to tot (34.84 KB, patch)
2011-08-30 04:45 PDT, Antti Koivisto 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
build fix (34.86 KB, patch)
2011-08-30 07:41 PDT, Antti Koivisto 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
style & win build fix (35.39 KB, patch)
2011-08-30 08:15 PDT, Antti Koivisto 		sam: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2011-08-29 16:04:01 PDT 
Descendant and child selectors can be matches substantially faster using SelectorChecker::fastCheckSelector() path. Currently it is used for style matching only.
Comment 1 Antti Koivisto 2011-08-29 16:38:23 PDT 
Created attachment 105542 [details]
patch, missing non-Mac build files

The patch is ~25% speedup in the overall native score of http://www.webkit.org/perf/slickspeed/. Some individual subtests (using child or descendant selectors) execute twice as fast.
Comment 2 Antti Koivisto 2011-08-30 02:42:57 PDT 
Created attachment 105602 [details]
patch
Comment 3 Antti Koivisto 2011-08-30 04:45:59 PDT 
Created attachment 105615 [details]
updated to tot
Comment 4 WebKit Review Bot 2011-08-30 04:50:16 PDT 
Comment on attachment 105615 [details]
updated to tot

Attachment 105615 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9565414
Comment 5 Gyuyoung Kim 2011-08-30 04:50:22 PDT 
Comment on attachment 105615 [details]
updated to tot

Attachment 105615 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9566377
Comment 6 Early Warning System Bot 2011-08-30 04:54:34 PDT 
Comment on attachment 105615 [details]
updated to tot

Attachment 105615 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9565415
Comment 7 WebKit Review Bot 2011-08-30 06:23:21 PDT 
Comment on attachment 105615 [details]
updated to tot

Attachment 105615 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9563470
Comment 8 Antti Koivisto 2011-08-30 07:41:35 PDT 
Created attachment 105626 [details]
build fix
Comment 9 WebKit Review Bot 2011-08-30 07:43:34 PDT 
Attachment 105626 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/SelectorQuery.h:54:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Gyuyoung Kim 2011-08-30 07:50:17 PDT 
Comment on attachment 105626 [details]
build fix

Attachment 105626 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9558602
Comment 11 Dimitri Glazkov (Google) 2011-08-30 07:55:21 PDT 
This is really cool stuff, Antti.
Comment 12 Antti Koivisto 2011-08-30 08:15:37 PDT 
Created attachment 105631 [details]
style & win build fix
Comment 13 Gyuyoung Kim 2011-08-30 08:20:18 PDT 
Comment on attachment 105631 [details]
style & win build fix

Attachment 105631 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9563499
Comment 14 Sam Weinig 2011-08-30 10:19:50 PDT 
Comment on attachment 105631 [details]
style & win build fix

Awesome! r=me, but do what Adam says about the windows build file.
Comment 15 Antti Koivisto 2011-08-30 10:43:30 PDT 
http://trac.webkit.org/changeset/94089