Bug 6716 - cleanup patch for duplicated code in quartz gradient drawing
Summary: cleanup patch for duplicated code in quartz gradient drawing
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Normal
Assignee: Nobody
URL: http://welcome.linux.org.il/welcome-t...
Keywords: SVGHitList
Depends on:
Blocks: 7199
  Show dependency tree / graph
 
Reported: 2006-01-22 14:10 PST by Eric Seidel (no email)
Modified: 2006-02-15 21:28 PST (History)
1 user (show)

See Also:

Attachments
reduction (512 bytes, image/svg+xml)
2006-01-28 03:54 PST, Alexander Kellett 		no flags Details
cleanup patch (23.66 KB, patch)
2006-02-06 13:48 PST, Alexander Kellett 		eric: review-
Details | Formatted Diff | Diff
cleanup patch (23.13 KB, patch)
2006-02-09 00:49 PST, Alexander Kellett 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-01-22 14:10:58 PST 
Gradient appears and disappears in SVG

http://welcome.linux.org.il/welcome-to-linux-2004.svg

We'll need to reduce this to figure out what's going wrong.
Comment 1 Eric Seidel (no email) 2006-01-26 16:21:32 PST 
High visibility user issue.  SVGHitList.
Comment 2 Alexander Kellett 2006-01-28 03:29:01 PST 
does not render with a gradient in either opera or firefox, however, this is not serious enough to be a hitlist / p2 item, so removing the keyword and making p3
Comment 3 Alexander Kellett 2006-01-28 03:54:07 PST 
Created attachment 6042 [details]
reduction
Comment 4 Alexander Kellett 2006-01-28 03:55:05 PST 
have a reduction now, making hitlist as this shows a major bug in gradient filled text
Comment 5 Alexander Kellett 2006-02-06 13:48:28 PST 
Created attachment 6302 [details]
cleanup patch
Comment 6 Eric Seidel (no email) 2006-02-09 00:43:34 PST 
Comment on attachment 6302 [details]
cleanup patch

We talked about this on irc.  This can be done cleaner w/o addin a new "BaseClass" class.
Comment 7 Alexander Kellett 2006-02-09 00:49:09 PST 
Created attachment 6358 [details]
cleanup patch
Comment 8 Maciej Stachowiak 2006-02-09 01:52:41 PST 
Comment on attachment 6358 [details]
cleanup patch

r=me
Comment 9 Adele Peterson 2006-02-11 12:15:05 PST 
Maciej committed this.