Bug 67141 - Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
Summary: Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setForm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 66241
  Show dependency treegraph
 
Reported: 2011-08-29 11:34 PDT by Ryosuke Niwa
Modified: 2011-08-29 13:18 PDT (History)
6 users (show)

See Also:


Attachments
cleanup (9.84 KB, patch)
2011-08-29 11:40 PDT, Ryosuke Niwa
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-08-29 11:34:04 PDT
notifyFormStateChanged is duplicated in HTMLInputElement and HTMLTextAreaElement (one is a static local function, and the other one is a member of HTMLInputElement).  Also formControlValueMatchesRenderer and setFormControlValueMatchesRenderer are somehow member functions of Node, which is probably a left-over from WML.
Comment 1 Ryosuke Niwa 2011-08-29 11:40:44 PDT
Created attachment 105506 [details]
cleanup
Comment 2 Ryosuke Niwa 2011-08-29 11:41:16 PDT
I just had to refactor code.  The existing code was too disgusting.
Comment 3 Eric Seidel (no email) 2011-08-29 11:51:58 PDT
Comment on attachment 105506 [details]
cleanup

LGTM.
Comment 4 Eric Seidel (no email) 2011-08-29 12:04:04 PDT
Comment on attachment 105506 [details]
cleanup

Attachment 105506 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9569063
Comment 5 Ryosuke Niwa 2011-08-29 13:18:51 PDT
Committed r94009: <http://trac.webkit.org/changeset/94009>