Bug 67140 - Assertion failure in RenderLayer::computeRepaintRects when scrolling
Summary: Assertion failure in RenderLayer::computeRepaintRects when scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 11:08 PDT by Julien Chaffraix
Modified: 2011-08-29 14:32 PDT (History)
1 user (show)

See Also:

Attachments
WIP patch, missing baseline for mac. (5.74 KB, patch)
2011-08-29 11:41 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Proposed fix: Bail early if we see a layer with no visible content. (8.89 KB, patch)
2011-08-29 12:24 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Patch for landing (8.89 KB, patch)
2011-08-29 13:52 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-08-29 11:08:45 PDT 
r93837 added an ASSERT when calling computeRepaintRects. It looks like it is hit when scrolling, likely in the following code:

RenderLayer::updateLayerPositionsAfterScroll(bool fixed)
{
    (...)


        computeRepaintRects();

We do not check if the layer is visible (in which case we could likely return early as empty layers have no repaint rectangles anyway).
Comment 1 Julien Chaffraix 2011-08-29 11:41:28 PDT 
Created attachment 105507 [details]
WIP patch, missing baseline for mac.
Comment 2 Julien Chaffraix 2011-08-29 12:24:14 PDT 
Created attachment 105509 [details]
Proposed fix: Bail early if we see a layer with no visible content.
Comment 3 Dave Hyatt 2011-08-29 13:40:40 PDT 
Comment on attachment 105509 [details]
Proposed fix: Bail early if we see a layer with no visible content.

View in context: https://bugs.webkit.org/attachment.cgi?id=105509&action=review

r=me

> Source/WebCore/rendering/RenderLayer.cpp:394
> +    // they will be empty. If our visibility change, we are expected to recompute all

Typo. Should be "changes"
Comment 4 Julien Chaffraix 2011-08-29 13:52:02 PDT 
Created attachment 105518 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-08-29 14:32:20 PDT 
Comment on attachment 105518 [details]
Patch for landing

Clearing flags on attachment: 105518

Committed r94016: <http://trac.webkit.org/changeset/94016>
Comment 6 WebKit Review Bot 2011-08-29 14:32:24 PDT 
All reviewed patches have been landed.  Closing bug.