Bug 67117 - unused ScrollView* argument should be removed from scrollRectIntoView
: unused ScrollView* argument should be removed from scrollRectIntoView
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit API
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-29 04:00 PDT by Kaustubh Atrawalkar
Modified: 2011-08-30 10:00 PDT (History)
2 users (show)

See Also:


Attachments
unused ScrollView* argument should be removed from scrollRectIntoView (19.02 KB, patch)
2011-08-29 04:14 PDT, Kaustubh Atrawalkar
morrita: review-
webkit.review.bot: commit‑queue-
Details | Formatted Diff | Diff
Updated patch (19.12 KB, patch)
2011-08-30 04:10 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kaustubh Atrawalkar 2011-08-29 04:00:56 PDT
The unused ScrollView* argument can and should be removed from scrollRectIntoView
Comment 1 Kaustubh Atrawalkar 2011-08-29 04:14:12 PDT
Created attachment 105480 [details]
unused ScrollView* argument should be removed from scrollRectIntoView
Comment 2 WebKit Review Bot 2011-08-29 04:25:37 PDT
Comment on attachment 105480 [details]
unused ScrollView* argument should be removed from scrollRectIntoView

Attachment 105480 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9561145
Comment 3 Hajime Morrita 2011-08-29 04:37:53 PDT
Comment on attachment 105480 [details]
unused ScrollView* argument should be removed from scrollRectIntoView

r- for chromium build failure.
Comment 4 Kaustubh Atrawalkar 2011-08-30 04:10:33 PDT
Created attachment 105611 [details]
Updated patch
Comment 5 WebKit Review Bot 2011-08-30 09:09:17 PDT
Comment on attachment 105611 [details]
Updated patch

Clearing flags on attachment: 105611

Committed r94080: <http://trac.webkit.org/changeset/94080>
Comment 6 WebKit Review Bot 2011-08-30 09:09:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Tony Chang 2011-08-30 10:00:52 PDT
Comment on attachment 105611 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105611&action=review

> Source/WebCore/page/ChromeClient.h:171
> +        virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.

Did you mean to remove the const here?  I'll add it back.