RESOLVED FIXED 67117
unused ScrollView* argument should be removed from scrollRectIntoView 
https://bugs.webkit.org/show_bug.cgi?id=67117
Summary unused ScrollView* argument should be removed from scrollRectIntoView
Kaustubh Atrawalkar
Reported 2011-08-29 04:00:56 PDT
The unused ScrollView* argument can and should be removed from scrollRectIntoView
Attachments
unused ScrollView* argument should be removed from scrollRectIntoView (19.02 KB, patch)
2011-08-29 04:14 PDT, Kaustubh Atrawalkar 		morrita: review-
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Updated patch (19.12 KB, patch)
2011-08-30 04:10 PDT, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kaustubh Atrawalkar
Comment 1 2011-08-29 04:14:12 PDT
Created attachment 105480 [details] unused ScrollView* argument should be removed from scrollRectIntoView
WebKit Review Bot
Comment 2 2011-08-29 04:25:37 PDT
Comment on attachment 105480 [details] unused ScrollView* argument should be removed from scrollRectIntoView Attachment 105480 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9561145
Hajime Morrita
Comment 3 2011-08-29 04:37:53 PDT
Comment on attachment 105480 [details] unused ScrollView* argument should be removed from scrollRectIntoView r- for chromium build failure.
Kaustubh Atrawalkar
Comment 4 2011-08-30 04:10:33 PDT
Created attachment 105611 [details] Updated patch
WebKit Review Bot
Comment 5 2011-08-30 09:09:17 PDT
Comment on attachment 105611 [details] Updated patch Clearing flags on attachment: 105611 Committed r94080: <http://trac.webkit.org/changeset/94080>
WebKit Review Bot
Comment 6 2011-08-30 09:09:22 PDT
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 7 2011-08-30 10:00:52 PDT
Comment on attachment 105611 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=105611&action=review > Source/WebCore/page/ChromeClient.h:171 > + virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation. Did you mean to remove the const here? I'll add it back.
Note You need to log in before you can comment on or make changes to this bug.