Bug 67117 - unused ScrollView* argument should be removed from scrollRectIntoView
: unused ScrollView* argument should be removed from scrollRectIntoView
Status: RESOLVED FIXED
: WebKit
WebKit API
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-08-29 04:00 PST by
Modified: 2011-08-30 10:00 PST (History)


Attachments
unused ScrollView* argument should be removed from scrollRectIntoView (19.02 KB, patch)
2011-08-29 04:14 PST, Kaustubh Atrawalkar
morrita: review-
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Updated patch (19.12 KB, patch)
2011-08-30 04:10 PST, Kaustubh Atrawalkar
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-08-29 04:00:56 PST
The unused ScrollView* argument can and should be removed from scrollRectIntoView
------- Comment #1 From 2011-08-29 04:14:12 PST -------
Created an attachment (id=105480) [details]
unused ScrollView* argument should be removed from scrollRectIntoView
------- Comment #2 From 2011-08-29 04:25:37 PST -------
(From update of attachment 105480 [details])
Attachment 105480 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9561145
------- Comment #3 From 2011-08-29 04:37:53 PST -------
(From update of attachment 105480 [details])
r- for chromium build failure.
------- Comment #4 From 2011-08-30 04:10:33 PST -------
Created an attachment (id=105611) [details]
Updated patch
------- Comment #5 From 2011-08-30 09:09:17 PST -------
(From update of attachment 105611 [details])
Clearing flags on attachment: 105611

Committed r94080: <http://trac.webkit.org/changeset/94080>
------- Comment #6 From 2011-08-30 09:09:22 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #7 From 2011-08-30 10:00:52 PST -------
(From update of attachment 105611 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=105611&action=review

> Source/WebCore/page/ChromeClient.h:171
> +        virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.

Did you mean to remove the const here?  I'll add it back.