Bug 67104 - Update registerProtocolHandler scheme whitelist to match spec
Summary: Update registerProtocolHandler scheme whitelist to match spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Wells
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-28 22:12 PDT by Ben Wells
Modified: 2011-08-30 08:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2011-08-28 22:31 PDT, Ben Wells 		no flags Details | Formatted Diff | Diff
Patch (5.32 KB, patch)
2011-08-29 22:00 PDT, Ben Wells 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Wells 2011-08-28 22:12:14 PDT 
Update registerProtocolHandler scheme whitelist to match spec
Comment 1 Ben Wells 2011-08-28 22:31:08 PDT 
Created attachment 105460 [details]
Patch
Comment 2 Darin Adler 2011-08-29 10:57:09 PDT 
Comment on attachment 105460 [details]
Patch

Can we test this?
Comment 3 Adam Barth 2011-08-29 12:19:33 PDT 
> Can we test this?

Does registerProtocolHandler report some sort of error when you register something off the whitelist?  Maybe we could register something and try to use the registration?  Seems like it ought to be testable.
Comment 4 Ben Wells 2011-08-29 22:00:20 PDT 
Created attachment 105575 [details]
Patch
Comment 5 Ben Wells 2011-08-29 22:01:27 PDT 
Comment on attachment 105575 [details]
Patch

There is already a test which checks that schemes not in the whitelist fail to register. I've added to this test to make sure all schemes in the whitelist can be registered.
Comment 6 WebKit Review Bot 2011-08-30 08:59:53 PDT 
Comment on attachment 105575 [details]
Patch

Clearing flags on attachment: 105575

Committed r94079: <http://trac.webkit.org/changeset/94079>
Comment 7 WebKit Review Bot 2011-08-30 08:59:57 PDT 
All reviewed patches have been landed.  Closing bug.