Bug 67094 - [Qt][WK2] Qt layer should be hardened against C API versioning in the sense of build failures
Summary: [Qt][WK2] Qt layer should be hardened against C API versioning in the sense o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-08-28 12:29 PDT by Balazs Kelemen
Modified: 2011-09-11 20:20 PDT (History)
2 users (show)

See Also:


Attachments
proposed fix (4.04 KB, patch)
2011-09-06 05:14 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
fix v2 (4.28 KB, patch)
2011-09-07 01:29 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2011-08-28 12:29:25 PDT
A build fix related to C API versioning: http://trac.webkit.org/changeset/93949
I suggest to apply this style of initialization everywhere for consistency and to avoid future build breakages.
Comment 1 Balazs Kelemen 2011-09-06 05:14:53 PDT
Created attachment 106408 [details]
proposed fix
Comment 2 Balazs Kelemen 2011-09-07 01:15:28 PDT
Comment on attachment 106408 [details]
proposed fix

It's not correct. Since we always build against trunk we should use the current version of the client structures. This way we can notice functional changes that affect us. Another argument is that WebKit::APIClient except the version number and the layout of the structure is matching.
Comment 3 Balazs Kelemen 2011-09-07 01:29:55 PDT
Created attachment 106555 [details]
fix v2
Comment 4 Andreas Kling 2011-09-11 17:14:10 PDT
Comment on attachment 106555 [details]
fix v2

LGTM.
Comment 5 WebKit Review Bot 2011-09-11 20:20:35 PDT
Comment on attachment 106555 [details]
fix v2

Clearing flags on attachment: 106555

Committed r94937: <http://trac.webkit.org/changeset/94937>
Comment 6 WebKit Review Bot 2011-09-11 20:20:39 PDT
All reviewed patches have been landed.  Closing bug.