WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
67076
iChat: Receiving a message containing only a single-quote (') causes bubble to fail
https://bugs.webkit.org/show_bug.cgi?id=67076
Summary
iChat: Receiving a message containing only a single-quote (') causes bubble t...
Anders Carlsson
Reported
2011-08-26 17:58:57 PDT
iChat: Receiving a message containing only a single-quote (') causes bubble to fail
Attachments
Patch
(24.22 KB, patch)
2011-08-26 18:02 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-08-26 18:02:04 PDT
Created
attachment 105428
[details]
Patch
Darin Adler
Comment 2
2011-08-27 12:01:02 PDT
Dan, would you care to explain the review- for those of us watching from the “peanut gallery”?
mitz
Comment 3
2011-08-27 12:09:22 PDT
(In reply to
comment #2
)
> Dan, would you care to explain the review- for those of us watching from the “peanut gallery”?
Sorry, I explained it to Anders in person of course, but I should have commented here, too. The problem is capping “left” and “right” values using the original “width” and “0” (±border and padding) rather than the original “right” and “left” (±border and padding). This doesn’t work when the original x is not 0.
mitz
Comment 4
2011-08-27 12:45:32 PDT
Comment on
attachment 105428
[details]
Patch I was wrong!
Anders Carlsson
Comment 5
2011-08-27 13:22:40 PDT
Committed
r93943
: <
http://trac.webkit.org/changeset/93943
>
mitz
Comment 6
2011-08-27 13:28:24 PDT
<
rdar://problem/10026089
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug