WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
67062
Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
https://bugs.webkit.org/show_bug.cgi?id=67062
Summary
Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
Anders Carlsson
Reported
2011-08-26 13:36:54 PDT
Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
Attachments
Patch
(7.43 KB, patch)
2011-08-26 13:41 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-08-26 13:41:04 PDT
Created
attachment 105402
[details]
Patch
Sam Weinig
Comment 2
2011-08-26 13:45:56 PDT
Comment on
attachment 105402
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=105402&action=review
> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:338 > +void NetscapePlugin::Timer::start(bool throttle) > +{
Please remove the parameter.
> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:256 > + NetscapePlugin* m_netscapePlugin;
Please put a comment here explaining the lifetime of this pointer.
Anders Carlsson
Comment 3
2011-08-26 14:36:47 PDT
Committed
r93912
: <
http://trac.webkit.org/changeset/93912
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug