Bug 67062 - Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
Summary: Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 13:36 PDT by Anders Carlsson
Modified: 2011-08-26 14:36 PDT (History)
0 users

See Also:

Attachments
Patch (7.43 KB, patch)
2011-08-26 13:41 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-08-26 13:36:54 PDT 
Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
Comment 1 Anders Carlsson 2011-08-26 13:41:04 PDT 
Created attachment 105402 [details]
Patch
Comment 2 Sam Weinig 2011-08-26 13:45:56 PDT 
Comment on attachment 105402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105402&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:338
> +void NetscapePlugin::Timer::start(bool throttle)
> +{

Please remove the parameter.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:256
> +        NetscapePlugin* m_netscapePlugin;

Please put a comment here explaining the lifetime of this pointer.
Comment 3 Anders Carlsson 2011-08-26 14:36:47 PDT 
Committed r93912: <http://trac.webkit.org/changeset/93912>