RESOLVED DUPLICATE of bug 68041 67052
Remove offset hack from GraphicsContextCG setShadow code 
https://bugs.webkit.org/show_bug.cgi?id=67052
Summary Remove offset hack from GraphicsContextCG setShadow code
Matthew Delaney
Reported 2011-08-26 12:26:14 PDT
A hack was introduced in http://trac.webkit.org/changeset/28714 for an issue with offsets in an old version of cg that's long since been fixed. Since this hack is no longer necessary it's best removed.
Attachments
Patch (1.98 KB, patch)
2011-08-26 12:53 PDT, Matthew Delaney 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2011-08-26 12:53:27 PDT
Created attachment 105393 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-08-26 13:16:26 PDT
Comment on attachment 105393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105393&action=review > Source/WebCore/ChangeLog:3 > + Remove offset hack from graphicscontextcg setShadow code graphicscontextcg -> GraphicsContextCG > Source/WebCore/ChangeLog:12 > + for an issue with offsets in an old version of cg that's long since been fixed. cg -> CoreGraphics.
Matthew Delaney
Comment 3 2011-08-26 15:26:43 PDT
Committed r93919: <http://trac.webkit.org/changeset/93919>
Radar WebKit Bug Importer
Comment 4 2011-08-26 16:06:30 PDT
<rdar://problem/10033019>
Simon Fraser (smfr)
Comment 5 2011-08-29 15:47:26 PDT
...but conditionality put back via bug 67107.
Simon Fraser (smfr)
Comment 6 2011-09-09 10:47:12 PDT
This seems to have affected LayoutTests/fast/repaint/box-shadow-h.html
Dave Hyatt
Comment 7 2011-09-09 11:11:57 PDT
box-shadow-v.html as well.
Matthew Delaney
Comment 8 2011-09-09 11:37:03 PDT
Unless I'm misreading the tests, it appears that they're "more" correct now. The only difference is the non-blurred shadow above the last "lorem ipsum" - It now shows an offset of -5,-5 as requested, instead of having only the x and y offset component for the vertical and horizontal tests, respectively. I haven't double checked to see if those tests (using box-shadow) hit the ShadowBlur code path or not. If they do, then this patch wouldn't have affected that, correct?
Matthew Delaney
Comment 9 2011-09-09 11:53:27 PDT
Hmm, reverting my change for Lion does show those tests changing. So, again, unless I'm misreading it then this change helps us on those tests and we should rebaseline them. I can do that if others agree.
mitz
Comment 10 2011-09-13 16:19:50 PDT
This is now broken in TOT in OS X Lion: <div style="width: 100px; height: 100px; -webkit-box-shadow: black 1px 1px; background: red;">
Simon Fraser (smfr)
Comment 11 2011-09-13 16:22:40 PDT
Reopening.
mitz
Comment 12 2011-09-13 16:28:15 PDT
Filed bug 68041.
Matthew Delaney
Comment 13 2011-09-15 14:22:49 PDT
This issue is resolved by https://bugs.webkit.org/show_bug.cgi?id=68041. Closing. *** This bug has been marked as a duplicate of bug 68041 ***
Note You need to log in before you can comment on or make changes to this bug.