Bug 67039 - Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
Summary: Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 09:38 PDT by Pavel Feldman
Modified: 2011-08-26 09:57 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2011-08-26 09:50 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-08-26 09:38:02 PDT 
Fix to follow.
Comment 1 Pavel Feldman 2011-08-26 09:46:08 PDT 
Total problems found:

1. Popup renamed to Popover in half of the places, as a result, this._hidePopoverTimer is not getting removed. [regression]
2. contentElement.addEventListener("mousemove", this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true); was entirely forgotten and caused this [regression].
3. Strange delete this._popupInstanceMarker in the code

We will need to hold off commits like this in the future since they compromise the "polish" activity we are performing.
Comment 2 Pavel Feldman 2011-08-26 09:50:45 PDT 
Created attachment 105366 [details]
Patch
Comment 3 Yury Semikhatsky 2011-08-26 09:55:24 PDT 
Comment on attachment 105366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105366&action=review

> Source/WebCore/inspector/front-end/Popover.js:33
> + * @param {WebInspector.Popover} popoverHelper

Popover -> PopoverHelper=?
Comment 4 Pavel Feldman 2011-08-26 09:57:48 PDT 
Committed r93882: <http://trac.webkit.org/changeset/93882>