Bug 67030 - Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.
Summary: Web Inspector: Debugger.setBreakpointByUrl should return error when setting b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 04:07 PDT by Pavel Podivilov
Modified: 2011-08-29 01:54 PDT (History)
12 users (show)

See Also:

Attachments
Patch (12.50 KB, patch)
2011-08-26 04:11 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch (12.40 KB, patch)
2011-08-26 04:50 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-08-26 04:07:08 PDT 
Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.

Currently it just returns empty breakpointId without any error message which is confusing.

Original request: http://code.google.com/p/chromium/issues/detail?id=87879.
Comment 1 Pavel Podivilov 2011-08-26 04:11:42 PDT 
Created attachment 105344 [details]
Patch
Comment 2 Pavel Podivilov 2011-08-26 04:12:57 PDT 
* Add error message.
* Add test that sets breakpoint in the same location twice.
* Rename debugger-pause-on-breakpoint -> set-breakpoint.
Comment 3 WebKit Review Bot 2011-08-26 04:35:14 PDT 
Comment on attachment 105344 [details]
Patch

Attachment 105344 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9541010

New failing tests:
inspector/debugger/set-breakpoint.html
Comment 4 Pavel Podivilov 2011-08-26 04:50:04 PDT 
Created attachment 105346 [details]
Patch
Comment 5 Pavel Podivilov 2011-08-29 01:54:04 PDT 
Committed r93962: <http://trac.webkit.org/changeset/93962>