Bug 67019 – Add layout test for locale-based font selection

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Matt Falkenhagen]

Add layout test for -webkit-locale based font selection (bug 10874).

I would assign this to myself but it seems I can't edit that field.

[Matt Falkenhagen]

Created attachment 105319 [details]
Patch

[Matt Falkenhagen]

There are no expectations yet since default per-script fonts are not set for any platform (except Chrome OS). I thought we could add the test now and add expectations as the defaults come in.

[Darin Adler]

Comment on attachment 105319 [details]
Patch

New regression tests need to come with expected results files. It’s not correct to add a test without the results.

[Matt Falkenhagen]

Created attachment 113829 [details]
Patch

[Matt Falkenhagen]

Created attachment 113830 [details]
expected result

Here is the expected result generated on my machine (I didn't include in the patch as my machine settings may differ from the buildbots).

[Kent Tamura]

Comment on attachment 113829 [details]
Patch

> I didn't include in the patch as my machine settings may differ from the buildbots

Ok, it sounds reasonable.

[WebKit Review Bot]

Comment on attachment 113829 [details]
Patch

Rejecting attachment 113829 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Tests/platform/efl/Skipped
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 succeeded at 456 with fuzz 2 (offset 12 lines).
patching file LayoutTests/platform/mac/Skipped
patching file LayoutTests/platform/qt/Skipped
patching file LayoutTests/platform/win/Skipped
patching file LayoutTests/platform/wincairo/Skipped
patching file LayoutTests/platform/wk2/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10332591

[Matt Falkenhagen]

Created attachment 113838 [details]
Patch

[WebKit Review Bot]

Comment on attachment 113838 [details]
Patch

Rejecting attachment 113838 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10337730

[WebKit Review Bot]

Comment on attachment 113838 [details]
Patch

Rejecting attachment 113838 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ayoutTests/platform/efl/Skipped
patching file LayoutTests/platform/gtk-wk2/Skipped
patching file LayoutTests/platform/gtk/Skipped
patching file LayoutTests/platform/mac/Skipped
patching file LayoutTests/platform/qt/Skipped
patching file LayoutTests/platform/win/Skipped
patching file LayoutTests/platform/wincairo/Skipped
patching file LayoutTests/platform/wk2/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10333646

[Matt Falkenhagen]

Looks like it's conflicting with recent change: http://trac.webkit.org/changeset/99402

I'll rebase and try again tomorrow.

[Matt Falkenhagen]

Created attachment 113978 [details]
rebase

[WebKit Review Bot]

Comment on attachment 113978 [details]
rebase

Clearing flags on attachment: 113978

Committed r99517: <http://trac.webkit.org/changeset/99517>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

Baseline files were added by http://trac.webkit.org/changeset/99797