Bug 67015 – REGRESSION(r93390): Invalid maxlength attribute causes input to allow no text

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Shinya Kawanaka]

input having empty or invalid maxlength does not allow inserting text. Such a attribute should be ignored.

[Shinya Kawanaka]

Created attachment 105302 [details]
Patch

[Kent Tamura]

Comment on attachment 105302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105302&action=review

> LayoutTests/ChangeLog:3
> +        Empty or invalid maxlength of an input tag should be ignored.

Please prepend "REGRESSION(r93390): " to the summary.  It's a WebKit idiom for a regression.

> Source/WebCore/ChangeLog:3
> +        Empty or invalid maxlength of an input tag should be ignored.

ditto.

> Source/WebCore/html/HTMLInputElement.cpp:1926
> +    bool ok = true;
> +    int maxLength = attribute->isNull() ? maximumLength : attribute->value().toInt(&ok);
> +    if (!ok || maxLength < 0 || maxLength > maximumLength)

Please use parseHTMLInteger() in WebCore/html/parser/HTMLParserIdioms.h

[Shinya Kawanaka]

Created attachment 105321 [details]
Patch

[Kent Tamura]

Comment on attachment 105321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105321&action=review

> Source/WebCore/html/HTMLInputElement.cpp:1925
> +    if (attribute->isNull() || !parseHTMLInteger(attribute->value(), maxLength))

I think attribute->isNull()|| is not needed.

[Shinya Kawanaka]

Created attachment 105326 [details]
Patch

[Kent Tamura]

Comment on attachment 105326 [details]
Patch

ok.  Thank you for the quick fix!

[WebKit Review Bot]

Comment on attachment 105326 [details]
Patch

Clearing flags on attachment: 105326

Committed r93858: <http://trac.webkit.org/changeset/93858>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ilya Sherman]

Indeed, the quick fix is much appreciated.  Thank you!