RESOLVED FIXED 67010
Update topCallFrame when calling host functions in the JIT 
https://bugs.webkit.org/show_bug.cgi?id=67010
Summary Update topCallFrame when calling host functions in the JIT
Juan C. Montemayor
Reported 2011-08-25 18:48:49 PDT
The topCallFrame is not being updated when a host function is called by the JIT. This causes problems when trying to create a stack trace.
Attachments
Proposed patch (1.92 KB, patch)
2011-08-25 22:08 PDT, Juan C. Montemayor 		no flags
DetailsFormatted DiffDiff
sunspider test results showing no speed regression (3.27 KB, text/plain)
2011-08-25 22:13 PDT, Juan C. Montemayor 		no flags
Details
updated patch (1.93 KB, patch)
2011-08-26 10:17 PDT, Juan C. Montemayor 		no flags
DetailsFormatted DiffDiff
patch with changes (26.49 KB, patch)
2011-08-26 15:49 PDT, Juan C. Montemayor 		j.mont: review-
j.mont: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Juan C. Montemayor
Comment 1 2011-08-25 22:08:57 PDT
Created attachment 105308 [details] Proposed patch
Juan C. Montemayor
Comment 2 2011-08-25 22:13:14 PDT
Created attachment 105309 [details] sunspider test results showing no speed regression
Oliver Hunt
Comment 3 2011-08-26 09:59:43 PDT
Comment on attachment 105308 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=105308&action=review > Source/JavaScriptCore/jit/JITOpcodes.cpp:143 > + // Fixme: Should TopCallFrame also be uploaded at this location? yes
Juan C. Montemayor
Comment 4 2011-08-26 10:17:36 PDT
Created attachment 105370 [details] updated patch
WebKit Review Bot
Comment 5 2011-08-26 14:46:13 PDT
Comment on attachment 105370 [details] updated patch Clearing flags on attachment: 105370 Committed r93915: <http://trac.webkit.org/changeset/93915>
WebKit Review Bot
Comment 6 2011-08-26 14:46:17 PDT
All reviewed patches have been landed. Closing bug.
Juan C. Montemayor
Comment 7 2011-08-26 15:49:16 PDT
Created attachment 105416 [details] patch with changes
Note You need to log in before you can comment on or make changes to this bug.