Bug 66992 - garden-o-matic summary view should provide information on builders still in flight.
: garden-o-matic summary view should provide information on builders still in f...
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 66960
  Show dependency treegraph
 
Reported: 2011-08-25 15:46 PST by
Modified: 2011-08-25 16:13 PST (History)


Attachments
Patch (9.83 KB, patch)
2011-08-25 15:47 PST, Dimitri Glazkov (Google)
abarth: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-08-25 15:46:34 PST
garden-o-matic summary view should provide information on builders still in flight.
------- Comment #1 From 2011-08-25 15:47:55 PST -------
Created an attachment (id=105267) [details]
Patch
------- Comment #2 From 2011-08-25 15:59:38 PST -------
(From update of attachment 105267 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review

Very nice.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:97
> +        var failsFromRevision = failureAnalysis.newestPassingRevision + 1;

I'd put the word "implied" into the name of this variable (e.g., impliedFirstFailingRevision or something).  We don't actually know that the test fails in this revision.

Sorry to be so nit-picky about these revision range things.  We weren't careful about this sort of thing in webkitpy and we paid for it severely later.
------- Comment #3 From 2011-08-25 16:03:03 PST -------
Committed r93830: <http://trac.webkit.org/changeset/93830>
------- Comment #4 From 2011-08-25 16:13:19 PST -------
(From update of attachment 105267 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:97
>> +        var failsFromRevision = failureAnalysis.newestPassingRevision + 1;
> 
> I'd put the word "implied" into the name of this variable (e.g., impliedFirstFailingRevision or something).  We don't actually know that the test fails in this revision.
> 
> Sorry to be so nit-picky about these revision range things.  We weren't careful about this sort of thing in webkitpy and we paid for it severely later.

Sounds good! Done.