Bug 66992 - garden-o-matic summary view should provide information on builders still in flight.
: garden-o-matic summary view should provide information on builders still in f...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Dimitri Glazkov (Google)
:
Depends on:
Blocks: 66960
  Show dependency treegraph
 
Reported: 2011-08-25 15:46 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-25 16:13 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.83 KB, patch)
2011-08-25 15:47 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-25 15:46:34 PDT
garden-o-matic summary view should provide information on builders still in flight.
Comment 1 Dimitri Glazkov (Google) 2011-08-25 15:47:55 PDT
Created attachment 105267 [details]
Patch
Comment 2 Adam Barth 2011-08-25 15:59:38 PDT
Comment on attachment 105267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review

Very nice.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:97
> +        var failsFromRevision = failureAnalysis.newestPassingRevision + 1;

I'd put the word "implied" into the name of this variable (e.g., impliedFirstFailingRevision or something).  We don't actually know that the test fails in this revision.

Sorry to be so nit-picky about these revision range things.  We weren't careful about this sort of thing in webkitpy and we paid for it severely later.
Comment 3 Dimitri Glazkov (Google) 2011-08-25 16:03:03 PDT
Committed r93830: <http://trac.webkit.org/changeset/93830>
Comment 4 Dimitri Glazkov (Google) 2011-08-25 16:13:19 PDT
Comment on attachment 105267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:97
>> +        var failsFromRevision = failureAnalysis.newestPassingRevision + 1;
> 
> I'd put the word "implied" into the name of this variable (e.g., impliedFirstFailingRevision or something).  We don't actually know that the test fails in this revision.
> 
> Sorry to be so nit-picky about these revision range things.  We weren't careful about this sort of thing in webkitpy and we paid for it severely later.

Sounds good! Done.