Bug 66983 – Move file internal methods to a class continuation in WKView

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Move file internal methods to a class continuation in WKView

[Anders Carlsson]

Created attachment 105248 [details]
Patch

Comment on attachment 105248 [details]
Patch

r=me but while this is a neat way to do things in the future, changing existing code to use continuations has almost zero benefit and makes it harder to “svn annotate” source code, so perhaps we shouldn’t do it everywhere.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 105248 [details])
> r=me but while this is a neat way to do things in the future, changing existing code to use continuations has almost zero benefit and makes it harder to “svn annotate” source code, so perhaps we shouldn’t do it everywhere.

I agree.

[Anders Carlsson]

Committed r93825: <http://trac.webkit.org/changeset/93825>

[Darin Adler]

Do we still get an error or warning if we omit the method definitions?

[Anders Carlsson]

(In reply to comment #5)
> Do we still get an error or warning if we omit the method definitions?

Yes.

[Adam Roben (:aroben)]

What advantages over categories do class extensions provide?

[Adam Roben (:aroben)]

I guess maybe it makes it easier to change a method from being internal to public and vice-versa. You won't have to move the method within the file when doing that.

[Darin Adler]

The second, smaller advantage is that there’s no spurious “category name” that you have to chose.