Bug 66980 - Remove use of magic number -1 in WebCore/editing/visible_units.cpp
Summary: Remove use of magic number -1 in WebCore/editing/visible_units.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 14:28 PDT by Van Lam
Modified: 2011-08-25 16:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2011-08-25 14:31 PDT, Van Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Van Lam 2011-08-25 14:28:22 PDT 
Currently two functions greatestOffsetUnder and smallestOffsetAbove return -1 to indicate that the correct word boundary to move to is not found. Should be using a constant to make this more clear.
Comment 1 Van Lam 2011-08-25 14:31:55 PDT 
Created attachment 105243 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-25 16:19:39 PDT 
Comment on attachment 105243 [details]
Patch

Clearing flags on attachment: 105243

Committed r93834: <http://trac.webkit.org/changeset/93834>
Comment 3 WebKit Review Bot 2011-08-25 16:19:43 PDT 
All reviewed patches have been landed.  Closing bug.