Bug 66979 - Remove WKPageCreateSnapshotOfVisibleContent
Summary: Remove WKPageCreateSnapshotOfVisibleContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-08-25 14:06 PDT by Jessie Berlin
Modified: 2014-10-07 22:17 PDT (History)
5 users (show)

See Also:

Attachments
Part 1 (Gut WKPageCreateSnapshotOfVisibleContent) (6.85 KB, patch)
2011-08-25 14:43 PDT, Jessie Berlin 		no flags Details | Formatted Diff | Diff
A patch to remove existing the function stub. (2.25 KB, patch)
2014-10-07 18:17 PDT, Sungmann Cho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-08-25 14:06:26 PDT 
WKPageCreateSnapshotOfVisibleContent makes a sync call from the UI Process to the Web Process. It should be removed as soon as it is possible to do so without breaking the nightlies.

<rdar://problem/9314215>
Comment 1 Jessie Berlin 2011-08-25 14:08:50 PDT 
Part 1 of this should be gutting it - remove the code that actually does the sync call and have it always return 0.
Comment 2 Jessie Berlin 2011-08-25 14:43:29 PDT 
Created attachment 105249 [details]
Part 1 (Gut WKPageCreateSnapshotOfVisibleContent)
Comment 3 WebKit Review Bot 2011-08-26 09:15:39 PDT 
Comment on attachment 105249 [details]
Part 1 (Gut WKPageCreateSnapshotOfVisibleContent)

Clearing flags on attachment: 105249

Committed r93880: <http://trac.webkit.org/changeset/93880>
Comment 4 WebKit Review Bot 2011-08-26 09:15:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Jessie Berlin 2011-08-26 09:54:50 PDT 
Not quite done yet. Still have to remove the function altogether when it won’t break the nighties.
Comment 6 Sungmann Cho 2014-10-07 18:17:54 PDT 
Created attachment 239444 [details]
A patch to remove existing the function stub.
Comment 7 WebKit Commit Bot 2014-10-07 22:17:32 PDT 
Comment on attachment 239444 [details]
A patch to remove existing the function stub.

Clearing flags on attachment: 239444

Committed r174417: <http://trac.webkit.org/changeset/174417>
Comment 8 WebKit Commit Bot 2014-10-07 22:17:36 PDT 
All reviewed patches have been landed.  Closing bug.