Bug 66973 - WebViewImpl::selectionRange should return range in the right order.
Summary: WebViewImpl::selectionRange should return range in the right order.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 96508
  Show dependency tree / graph
 
Reported: 2011-08-25 13:14 PDT by Varun Jain
Modified: 2012-09-12 07:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2011-08-25 13:15 PDT, Varun Jain 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2011-08-26 10:14 PDT, Varun Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Varun Jain 2011-08-25 13:14:28 PDT 
WebViewImpl::selectionRange should return range in the right order.
Comment 1 Varun Jain 2011-08-25 13:15:20 PDT 
Created attachment 105234 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2011-08-26 10:03:56 PDT 
Comment on attachment 105234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105234&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1566
> +        WebPoint tmp = start;

nit: use std::swap here?
Comment 3 Varun Jain 2011-08-26 10:14:41 PDT 
Created attachment 105369 [details]
Patch
Comment 4 WebKit Review Bot 2011-08-26 11:07:52 PDT 
Comment on attachment 105369 [details]
Patch

Clearing flags on attachment: 105369

Committed r93893: <http://trac.webkit.org/changeset/93893>
Comment 5 WebKit Review Bot 2011-08-26 11:07:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Iain Merrick 2012-09-12 07:00:22 PDT 
Hi Varun, I just discovered that this has a bad interaction on Android with my recent change to WebFrameImpl::selectRange. I've filed a new bug to try to resolve the difference: https://bugs.webkit.org/show_bug.cgi?id=96508