Bug 66971 - garden-o-matic summary needs a mock view that could be used for working on styling
Summary: garden-o-matic summary needs a mock view that could be used for working on st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64188
  Show dependency treegraph
 
Reported: 2011-08-25 12:26 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-25 14:09 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.95 KB, patch)
2011-08-25 13:53 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-25 12:26:49 PDT
And possibly for manual testing of appearance.
Comment 1 Adam Barth 2011-08-25 13:13:58 PDT
One thought I had about this was to inject mock data at the "net" layer and use the rest of the code to generate some representative UI.
Comment 2 Dimitri Glazkov (Google) 2011-08-25 13:16:49 PDT
(In reply to comment #1)
> One thought I had about this was to inject mock data at the "net" layer and use the rest of the code to generate some representative UI.

Yes! I am building something very simple now -- I just need to have a quickly loading page, but we should totally aim for net simulator eventually.
Comment 3 Dimitri Glazkov (Google) 2011-08-25 13:53:10 PDT
Created attachment 105239 [details]
Patch
Comment 4 Adam Barth 2011-08-25 14:06:16 PDT
Comment on attachment 105239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105239&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:123
> +        failures.addCommitData({ time: minutesAgo(currentMinutesAgo++), revision: currentRevision++, title: bugTitles.cycle(), author: people.cycle(), reviewer: people.cycle() });

Holy long lines, batman.
Comment 5 Dimitri Glazkov (Google) 2011-08-25 14:06:59 PDT
(In reply to comment #4)
> (From update of attachment 105239 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105239&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:123
> > +        failures.addCommitData({ time: minutesAgo(currentMinutesAgo++), revision: currentRevision++, title: bugTitles.cycle(), author: people.cycle(), reviewer: people.cycle() });
> 
> Holy long lines, batman.

Will fix! :)
Comment 6 Dimitri Glazkov (Google) 2011-08-25 14:09:53 PDT
Committed r93823: <http://trac.webkit.org/changeset/93823>