Bug 66971 – garden-o-matic summary needs a mock view that could be used for working on styling

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dimitri Glazkov (Google)]

And possibly for manual testing of appearance.

[Adam Barth]

One thought I had about this was to inject mock data at the "net" layer and use the rest of the code to generate some representative UI.

[Dimitri Glazkov (Google)]

(In reply to comment #1)
> One thought I had about this was to inject mock data at the "net" layer and use the rest of the code to generate some representative UI.

Yes! I am building something very simple now -- I just need to have a quickly loading page, but we should totally aim for net simulator eventually.

[Dimitri Glazkov (Google)]

Created attachment 105239 [details]
Patch

[Adam Barth]

Comment on attachment 105239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105239&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:123
> +        failures.addCommitData({ time: minutesAgo(currentMinutesAgo++), revision: currentRevision++, title: bugTitles.cycle(), author: people.cycle(), reviewer: people.cycle() });

Holy long lines, batman.

[Dimitri Glazkov (Google)]

(In reply to comment #4)
> (From update of attachment 105239 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105239&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:123
> > +        failures.addCommitData({ time: minutesAgo(currentMinutesAgo++), revision: currentRevision++, title: bugTitles.cycle(), author: people.cycle(), reviewer: people.cycle() });
> 
> Holy long lines, batman.

Will fix! :)

[Dimitri Glazkov (Google)]

Committed r93823: <http://trac.webkit.org/changeset/93823>