Bug 66959 - Remove skiaContext methods from CCLayerTreeHost,CCLayerTreeHostImpl, and CCLayerTreeHostImpl*Proxy
Summary: Remove skiaContext methods from CCLayerTreeHost,CCLayerTreeHostImpl, and CCLa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 66807
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-25 10:45 PDT by Nat Duca
Modified: 2011-11-02 13:02 PDT (History)
3 users (show)

See Also:

Attachments
The hack (8.93 KB, patch)
2011-08-25 10:45 PDT, Nat Duca 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2011-08-25 10:45:03 PDT 
The CCLayerTreeHost family of classes have a hack in them that allows main-thread code to get to the skiaContext in order to keep accelerated painting working.

This is a violation of layering --- we do not want anything on the ContentLayer side to ever have access to LayerRenderer, GraphicsContext, or GrContext state.
Comment 1 Nat Duca 2011-08-25 10:45:40 PDT 
Created attachment 105216 [details]
The hack
Comment 2 Nat Duca 2011-11-02 13:02:58 PDT 
@alokp fixed this