This is the second level of the unzipping process described in https://bugs.webkit.org/show_bug.cgi?id=66567.
Created attachment 105291 [details] Patch
Comment on attachment 105291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105291&action=review > Source/JavaScriptCore/runtime/Executable.h:221 > +#else > + void finishCreation(JSGlobalData& globalData) > + { > + Base::finishCreation(globalData); > + } > +#endif Why is this needed? Don’t we already inherit the base function? Not sure why we’d need to override it with an inline that does the same thing. > Source/JavaScriptCore/runtime/Executable.h:291 > + UNUSED_PARAM(globalData); This is incorrect. The parameter is passed to the base class version of finishCreation so it is used.
Created attachment 105390 [details] Fixing review issues
Comment on attachment 105390 [details] Fixing review issues Clearing flags on attachment: 105390 Committed r93920: <http://trac.webkit.org/changeset/93920>
All reviewed patches have been landed. Closing bug.