Bug 66956 - REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
Summary: REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66571
  Show dependency treegraph
 
Reported: 2011-08-25 10:37 PDT by Csaba Osztrogonác
Modified: 2011-08-25 16:08 PDT (History)
7 users (show)

See Also:


Attachments
Rebaseline constants for patching GetByIdSlowCaseCall on ARM (2.23 KB, patch)
2011-08-25 12:12 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-08-25 10:37:44 PDT
Check the results for details:
http://build.webkit.sed.hu/builders/ARMv5%20Linux%20Qt%20Release%20%28Test%29/builds/3203
Comment 1 Oliver Hunt 2011-08-25 10:45:24 PDT
Could you include sample failures + stacktraces in these bugs?  It's much more useful than a slow loading link, and the given link doesn't include any stacktraces at all thus making it completely useless.

I suspect that the cause of these failures would be obvious to any Qt engineer who looked at them
Comment 2 Csaba Osztrogonác 2011-08-25 10:45:52 PDT
Zoltan (our ARM expert) said that he'll check this bug tomorrow morning.
Comment 3 Oliver Hunt 2011-08-25 10:48:44 PDT
(In reply to comment #2)
> Zoltan (our ARM expert) said that he'll check this bug tomorrow morning.


This should be trivial -- the problem is that the Qt bot isn't providing console output.  The problem is almost certainly going to be that the size of one of the getById insn sequences has changed and the constant just needs to be updated appropriately, the assertions for these branches even tell you what the new size should be.
Comment 4 Gabor Loki 2011-08-25 12:12:25 PDT
Created attachment 105230 [details]
Rebaseline constants for patching GetByIdSlowCaseCall on ARM

A quick fix for r93755
Comment 5 Oliver Hunt 2011-08-25 13:12:11 PDT
Comment on attachment 105230 [details]
Rebaseline constants for patching GetByIdSlowCaseCall on ARM

r=me!
Comment 6 WebKit Review Bot 2011-08-25 16:08:26 PDT
Comment on attachment 105230 [details]
Rebaseline constants for patching GetByIdSlowCaseCall on ARM

Clearing flags on attachment: 105230

Committed r93832: <http://trac.webkit.org/changeset/93832>
Comment 7 WebKit Review Bot 2011-08-25 16:08:30 PDT
All reviewed patches have been landed.  Closing bug.