On TAB key press, focus never moves to any anchor element present in the page. Default behavior should be to move the focus to any anchor element in the current tree scope of DOM. To enable focus on links from TAB key, the property KeyboardAccessTabsToLinks should be set to true by default.
Presumably we want to match WebKit1's defaults, which may be different on different platforms.
Created attachment 105200 [details] Initialize tabsToLinks property to true by default in WebPreferencesStore
(In reply to comment #1) > Presumably we want to match WebKit1's defaults, which may be different on different platforms. aroben, In WebKit1, ChromeClient::keyboardUIMode() is implemented by various ports individually they were setting individually it to true (by default only). In WebKit2, since WebChromeClient::keyboardUIMode() is common for all ports shouldn't it be set to true by default there itself. Rather than each port individually setting and sending the preference change to WebProcess.
(In reply to comment #0) > On TAB key press, focus never moves to any anchor element present in the page. Default behavior should be to move the focus to any anchor element in the current tree scope of DOM. > > To enable focus on links from TAB key, the property KeyboardAccessTabsToLinks should be set to true by default. I have verified for the issue in QT & GTK ports and it is present. The issue is solved in both these ports with the attached patch. I haven't been able to verify the issue and the patch on win/mac ports.
(In reply to comment #3) > (In reply to comment #1) > > Presumably we want to match WebKit1's defaults, which may be different on different platforms. > aroben, > In WebKit1, ChromeClient::keyboardUIMode() is implemented by various ports individually they were setting individually it to true (by default only). WebKit1 on Windows defaults to false. WebKit1 on Mac bases this value on a system-level setting, which itself defaults to false. So I don't think it's true that all WebKit1 ports default to true.
Created attachment 105323 [details] Set property TabsToLinks to true for GTK platform As per comments, I have reverted the setting of property to true in WebPreferencesStore and doing it specifically for GTK platform, while setting up the WebProcessCreationParameters.
(In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #1) > > > Presumably we want to match WebKit1's defaults, which may be different on different platforms. > > aroben, > > In WebKit1, ChromeClient::keyboardUIMode() is implemented by various ports individually they were setting individually it to true (by default only). > > WebKit1 on Windows defaults to false. WebKit1 on Mac bases this value on a system-level setting, which itself defaults to false. So I don't think it's true that all WebKit1 ports default to true. aroben, As per your comments, now I am setting in WebKit::WebPageProxy::creationParameters() specifically for GTK port only.
(In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #3) > > > (In reply to comment #1) > > > > Presumably we want to match WebKit1's defaults, which may be different on different platforms. > > > aroben, > > > In WebKit1, ChromeClient::keyboardUIMode() is implemented by various ports individually they were setting individually it to true (by default only). > > > > WebKit1 on Windows defaults to false. WebKit1 on Mac bases this value on a system-level setting, which itself defaults to false. So I don't think it's true that all WebKit1 ports default to true. > > aroben, > As per your comments, now I am setting in WebKit::WebPageProxy::creationParameters() specifically for GTK port only. aroben, Can you please check the reworked patch?
Comment on attachment 105323 [details] Set property TabsToLinks to true for GTK platform This doesn't seem like the right place or way to do this. You should be changing the default value for this preference for GTK only in WebPreferencesStore.h.
Created attachment 106095 [details] Initialize tabsToLinks property to true by default in WebPreferencesStore only for GTK platform As per comments setting the property of TabsToLinks to default true but only for GTK platform. Also, fixed couple of style errors reported by style script in WebPreferencesStore.h
Comment on attachment 106095 [details] Initialize tabsToLinks property to true by default in WebPreferencesStore only for GTK platform Nice!
Comment on attachment 106095 [details] Initialize tabsToLinks property to true by default in WebPreferencesStore only for GTK platform Clearing flags on attachment: 106095 Committed r94417: <http://trac.webkit.org/changeset/94417>
All reviewed patches have been landed. Closing bug.