Bug 66942 - [SKIA] Move forward decl of skia type outside namespace Webkit
Summary: [SKIA] Move forward decl of skia type outside namespace Webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Salomon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 07:48 PDT by Brian Salomon
Modified: 2011-08-25 09:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2011-08-25 07:49 PDT, Brian Salomon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Salomon 2011-08-25 07:48:44 PDT
[SKIA] Move forward decl of skia type outside namespace Webkit
Comment 1 Brian Salomon 2011-08-25 07:49:32 PDT
Created attachment 105191 [details]
Patch
Comment 2 Brian Salomon 2011-08-25 07:54:28 PDT
D'oh! I didn't notice that I was adding the forward decl inside of a namespace in my original patch.
Comment 3 Stephen White 2011-08-25 07:57:19 PDT
Comment on attachment 105191 [details]
Patch

Looks good.  r=me

Did this cause a build failure?  Or just that it would have in the future?
Comment 4 Brian Salomon 2011-08-25 08:01:48 PDT
There was no build failure. If left as is it would have caused the subclass implementations of grGLInterface() to have to cast from GrGLInterface* to the bogus WebKit::GrGLInterface* type.
Comment 5 WebKit Review Bot 2011-08-25 09:14:34 PDT
Comment on attachment 105191 [details]
Patch

Clearing flags on attachment: 105191

Committed r93791: <http://trac.webkit.org/changeset/93791>
Comment 6 WebKit Review Bot 2011-08-25 09:14:37 PDT
All reviewed patches have been landed.  Closing bug.